Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: timetable-import: add PF and Sim timing to the endpoint's response #6587

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Feb 7, 2024

Some things I'm not sure are good enough:

  • naming of variables
  • the macro for timing

linked to #6558

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (dae6528) 27.89% compared to head (d288be7) 27.88%.
Report is 2 commits behind head on dev.

Files Patch % Lines
editoast/src/views/timetable/import.rs 5.47% 69 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6587      +/-   ##
============================================
- Coverage     27.89%   27.88%   -0.01%     
- Complexity     2177     2178       +1     
============================================
  Files          1040     1040              
  Lines        127637   127678      +41     
  Branches       2610     2610              
============================================
+ Hits          35605    35607       +2     
- Misses        90501    90540      +39     
  Partials       1531     1531              
Flag Coverage Δ
core 79.38% <ø> (+<0.01%) ⬆️
editoast 75.24% <12.65%> (-0.07%) ⬇️
front 8.41% <100.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Castavo Castavo force-pushed the bpt/timetable-import/timings branch 2 times, most recently from cdb6fc7 to 02d267a Compare February 7, 2024 16:45
@Castavo Castavo marked this pull request as ready for review February 7, 2024 16:45
@Castavo Castavo requested review from a team as code owners February 7, 2024 16:45
@Castavo Castavo requested review from leovalais and bloussou February 7, 2024 16:46
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for tests/

@Castavo Castavo self-assigned this Feb 8, 2024
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Namings and the macro is okay.

@Castavo Castavo force-pushed the bpt/timetable-import/timings branch from 02d267a to 59be1c3 Compare February 9, 2024 16:48
for pathfinding and simulation
@Castavo Castavo force-pushed the bpt/timetable-import/timings branch from 59be1c3 to d288be7 Compare February 9, 2024 17:37
@Castavo Castavo added this pull request to the merge queue Feb 12, 2024
Merged via the queue into dev with commit eee07b8 Feb 12, 2024
22 checks passed
@Castavo Castavo deleted the bpt/timetable-import/timings branch February 12, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants