-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: timetable-import: add PF and Sim timing to the endpoint's response #6587
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6587 +/- ##
============================================
- Coverage 27.89% 27.88% -0.01%
- Complexity 2177 2178 +1
============================================
Files 1040 1040
Lines 127637 127678 +41
Branches 2610 2610
============================================
+ Hits 35605 35607 +2
- Misses 90501 90540 +39
Partials 1531 1531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cdb6fc7
to
02d267a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for tests/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Namings and the macro is okay.
02d267a
to
59be1c3
Compare
for pathfinding and simulation
59be1c3
to
d288be7
Compare
Some things I'm not sure are good enough:
linked to #6558