-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: use serial_test #6249
Conversation
1b11185
to
19895f8
Compare
dd70e17
to
91b624b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6249 +/- ##
============================================
- Coverage 27.66% 27.66% -0.01%
Complexity 2136 2136
============================================
Files 990 990
Lines 125902 125902
Branches 2575 2575
============================================
- Hits 34832 34831 -1
- Misses 89580 89581 +1
Partials 1490 1490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3f6510d
to
cb368c5
Compare
Thanks for the PR. I'm a bit skeptical for reasons I explained in #5886. Sorry I didn't notice earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also surprised that 175 tests need to be serialsed
For some of them we could do as for the rolling stocks and change the hard coded string which break unicity constraints I believe
Also, have you considered creating several serial "threads" (like described in the docs) ?
I feel like not all tests which are serialized here need to be isolated from all other tests.
e91e5b7
to
a394c63
Compare
a394c63
to
da59a04
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
da59a04
to
ccfbdff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ccfbdff
to
75c7d19
Compare
close #5886
#6200 Before
#After