Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: use serial_test #6249

Merged
merged 1 commit into from
Jan 11, 2024
Merged

editoast: use serial_test #6249

merged 1 commit into from
Jan 11, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Jan 2, 2024

close #5886
#6200 Before
Capture d’écran 2024-01-02 à 15 51 13

#After
Screenshot 2024-01-03 at 14-59-19 editoast use serial_test · osrd-project_osrd@8ed6d06

@Wadjetz Wadjetz changed the title Ebe/editoast use serial test editoast: use serial_test Jan 2, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-use-serial-test branch 2 times, most recently from 1b11185 to 19895f8 Compare January 2, 2024 12:33
@Wadjetz Wadjetz self-assigned this Jan 2, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-use-serial-test branch 3 times, most recently from dd70e17 to 91b624b Compare January 2, 2024 14:28
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf6da3d) 27.66% compared to head (75c7d19) 27.66%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6249      +/-   ##
============================================
- Coverage     27.66%   27.66%   -0.01%     
  Complexity     2136     2136              
============================================
  Files           990      990              
  Lines        125902   125902              
  Branches       2575     2575              
============================================
- Hits          34832    34831       -1     
- Misses        89580    89581       +1     
  Partials       1490     1490              
Flag Coverage Δ
core 78.88% <ø> (ø)
editoast 75.58% <100.00%> (-0.01%) ⬇️
front 8.70% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-use-serial-test branch 3 times, most recently from 3f6510d to cb368c5 Compare January 2, 2024 17:13
@Wadjetz Wadjetz marked this pull request as ready for review January 3, 2024 09:11
@Wadjetz Wadjetz requested review from a team as code owners January 3, 2024 09:11
@Wadjetz Wadjetz added the area:editoast Work on Editoast Service label Jan 3, 2024
@Wadjetz Wadjetz requested a review from Castavo January 3, 2024 09:13
@shenriotpro
Copy link
Contributor

Thanks for the PR. I'm a bit skeptical for reasons I explained in #5886. Sorry I didn't notice earlier.

Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also surprised that 175 tests need to be serialsed

For some of them we could do as for the rolling stocks and change the hard coded string which break unicity constraints I believe

Also, have you considered creating several serial "threads" (like described in the docs) ?
I feel like not all tests which are serialized here need to be isolated from all other tests.

editoast/README.md Outdated Show resolved Hide resolved
@Wadjetz Wadjetz force-pushed the ebe/editoast-use-serial-test branch 4 times, most recently from e91e5b7 to a394c63 Compare January 3, 2024 14:11
@Wadjetz Wadjetz force-pushed the ebe/editoast-use-serial-test branch from a394c63 to da59a04 Compare January 3, 2024 15:24
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Wadjetz Wadjetz requested a review from Tguisnet January 5, 2024 08:34
@Wadjetz Wadjetz force-pushed the ebe/editoast-use-serial-test branch from da59a04 to ccfbdff Compare January 5, 2024 08:45
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

@Wadjetz Wadjetz enabled auto-merge January 5, 2024 15:36
@Wadjetz Wadjetz requested review from Castavo, multun and ElysaSrc January 5, 2024 16:02
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wadjetz Wadjetz added this pull request to the merge queue Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 11, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-use-serial-test branch from ccfbdff to 75c7d19 Compare January 11, 2024 14:55
@Wadjetz Wadjetz added this pull request to the merge queue Jan 11, 2024
Merged via the queue into dev with commit dc2b2d6 Jan 11, 2024
20 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-use-serial-test branch January 11, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast(test): use 'serial_test' crate for improving test performance
5 participants