fix: hide error box when there is 0 issues 🐛 #5691

tykayn · 2023-11-15T09:40:49Z

hide messages showing there is no anomaly when there is 0 issues in the editor

codecov · 2023-11-15T16:30:33Z

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5a4c741) 27.70% compared to head (35b02c1) 27.70%.
Report is 8 commits behind head on dev.

❗ Current head 35b02c1 differs from pull request most recent head b874d01. Consider uploading reports for the commit b874d01 to get more accurate results

Files	Patch %	Lines
front/src/applications/editor/Editor.tsx	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #5691      +/-   ##
============================================
- Coverage     27.70%   27.70%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1002     1002              
  Lines        126258   126260       +2     
  Branches       2580     2580              
============================================
- Hits          34978    34977       -1     
- Misses        89790    89793       +3     
  Partials       1490     1490

Flag	Coverage Δ
core	`78.58% <ø> (ø)`
editoast	`75.75% <ø> (-0.01%)`	⬇️
front	`8.35% <0.00%> (-0.01%)`	⬇️
gateway	`2.50% <ø> (ø)`
railjson_generator	`87.42% <ø> (ø)`
tests	`81.77% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

woshilapin

Looks good and if Codecov is happy, I'm too!

Khoyo · 2023-11-17T09:11:02Z

Please follow our commit style guide: https://osrd.fr/en/docs/guides/contribute/code/#git-commit-style

clarani

Thanks for your PR 🙏

.gitignore

codecov.yml

front/tests/005-operational-studies.spec.ts

front/tests/pages/home-page-model.ts

shenriotpro

Any chance you can rebase to remove irrelevant commits from this PR?

tykayn · 2023-12-06T17:01:40Z

Any chance you can rebase to remove irrelevant commits from this PR?

yup @shenriotpro i made a rebase and force pushed

shenriotpro · 2023-12-06T19:26:02Z

Any chance you can rebase to remove irrelevant commits from this PR?

yup @shenriotpro i made a rebase and force pushed

Great, thanks

Khoyo

The yarn.lock update seems out of scope too.

All of these should be done in separate PRs, or at least separate commits.

front/.gitignore

front/.yarnrc.yml

front/tests/005-operational-studies.spec.ts

Yohh

yop, I'm glad to see a new test file for our infra editor 💪 , can you add /editor/ in the grep key of the playwright config in playwright.config.ts ? if you don't add it the test can't be launch

Yohh

Also, can you rename the files related to the tests by specifying that it is the infra editor? (and not the rolling stock editor)

Yohh

nice! 💪

nicolaswurtz

Hi! Indentation is not correct, it must be 2 spaces.

nicolaswurtz

please split in 2 commits:

one for bug correction
one for adding test

front/playwright.config.ts

tykayn · 2024-01-22T10:22:07Z

After a request from @nicolaswurtz i am splitting the PR in two, one for the feature, and one to test the feature:
#6414

tykayn force-pushed the ble/fix-no-error-count branch from 5e79c45 to 8506033 Compare November 15, 2023 16:27

tykayn force-pushed the ble/fix-no-error-count branch from 8506033 to a724bd8 Compare November 15, 2023 17:01

woshilapin approved these changes Nov 16, 2023

View reviewed changes

clarani reviewed Nov 20, 2023

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

codecov.yml Outdated Show resolved Hide resolved

front/tests/005-operational-studies.spec.ts Outdated Show resolved Hide resolved

front/tests/pages/home-page-model.ts Outdated Show resolved Hide resolved

tykayn marked this pull request as ready for review November 27, 2023 09:23

tykayn requested a review from a team as a code owner November 27, 2023 09:23

tykayn force-pushed the ble/fix-no-error-count branch 2 times, most recently from 91933b1 to 8569450 Compare November 27, 2023 12:15

woshilapin requested a review from clarani December 4, 2023 13:36

tykayn requested review from a team, bloussou and nicolaswurtz as code owners December 5, 2023 17:56

tykayn requested a review from multun December 5, 2023 17:56

shenriotpro requested changes Dec 6, 2023

View reviewed changes

tykayn force-pushed the ble/fix-no-error-count branch from 39cc040 to ec1e301 Compare December 6, 2023 16:56

shenriotpro self-requested a review December 6, 2023 19:25

shenriotpro approved these changes Dec 6, 2023

View reviewed changes

tykayn force-pushed the ble/fix-no-error-count branch from ec1e301 to 87ecf68 Compare December 7, 2023 14:52

tykayn enabled auto-merge December 11, 2023 10:24

tykayn disabled auto-merge December 11, 2023 10:24

Khoyo reviewed Dec 11, 2023

View reviewed changes

front/.gitignore Outdated Show resolved Hide resolved

front/.yarnrc.yml Outdated Show resolved Hide resolved

flomonster removed request for a team December 12, 2023 08:36

flomonster removed request for multun and bloussou December 12, 2023 08:36

flomonster reviewed Dec 12, 2023

View reviewed changes

front/tests/005-operational-studies.spec.ts Outdated Show resolved Hide resolved

tykayn force-pushed the ble/fix-no-error-count branch 3 times, most recently from 2f7cbb3 to 1d6c58a Compare December 12, 2023 13:42

tykayn force-pushed the ble/fix-no-error-count branch from 1d6c58a to ffa8696 Compare January 18, 2024 14:23

tykayn enabled auto-merge January 18, 2024 14:59

Yohh reviewed Jan 18, 2024

View reviewed changes

tykayn force-pushed the ble/fix-no-error-count branch 2 times, most recently from bd680f3 to b124f1e Compare January 19, 2024 09:32

Yohh approved these changes Jan 19, 2024

View reviewed changes

nicolaswurtz suggested changes Jan 19, 2024

View reviewed changes

tykayn force-pushed the ble/fix-no-error-count branch from b124f1e to 0c5eea6 Compare January 19, 2024 10:45

nicolaswurtz suggested changes Jan 19, 2024

View reviewed changes

front/playwright.config.ts Outdated Show resolved Hide resolved

front: editor: hide the error box when there is no error

b874d01

tykayn force-pushed the ble/fix-no-error-count branch from 0c5eea6 to 35b02c1 Compare January 19, 2024 12:59

tykayn force-pushed the ble/fix-no-error-count branch from 35b02c1 to b874d01 Compare January 22, 2024 13:19

nicolaswurtz approved these changes Jan 22, 2024

View reviewed changes

tykayn added this pull request to the merge queue Jan 22, 2024

Merged via the queue into dev with commit 7ac9bc7 Jan 22, 2024
20 checks passed

tykayn deleted the ble/fix-no-error-count branch January 22, 2024 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: hide error box when there is 0 issues 🐛 #5691

fix: hide error box when there is 0 issues 🐛 #5691

tykayn commented Nov 15, 2023 •

edited by estia-m

Loading

codecov bot commented Nov 15, 2023 •

edited

Loading

woshilapin left a comment

Khoyo commented Nov 17, 2023

clarani left a comment

shenriotpro left a comment

tykayn commented Dec 6, 2023

shenriotpro commented Dec 6, 2023

Khoyo left a comment

Yohh left a comment

Yohh left a comment

Yohh left a comment

nicolaswurtz left a comment

nicolaswurtz left a comment

tykayn commented Jan 22, 2024

fix: hide error box when there is 0 issues 🐛 #5691

fix: hide error box when there is 0 issues 🐛 #5691

Conversation

tykayn commented Nov 15, 2023 • edited by estia-m Loading

codecov bot commented Nov 15, 2023 • edited Loading

Codecov Report

woshilapin left a comment

Choose a reason for hiding this comment

Khoyo commented Nov 17, 2023

clarani left a comment

Choose a reason for hiding this comment

shenriotpro left a comment

Choose a reason for hiding this comment

tykayn commented Dec 6, 2023

shenriotpro commented Dec 6, 2023

Khoyo left a comment

Choose a reason for hiding this comment

Yohh left a comment

Choose a reason for hiding this comment

Yohh left a comment

Choose a reason for hiding this comment

Yohh left a comment

Choose a reason for hiding this comment

nicolaswurtz left a comment

Choose a reason for hiding this comment

nicolaswurtz left a comment

Choose a reason for hiding this comment

tykayn commented Jan 22, 2024

tykayn commented Nov 15, 2023 •

edited by estia-m

Loading

codecov bot commented Nov 15, 2023 •

edited

Loading