Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove message and icon when the infrastructure has no errors and warnings #5632

Closed
bgiuliana opened this issue Nov 8, 2023 · 4 comments · Fixed by #5691
Closed

Remove message and icon when the infrastructure has no errors and warnings #5632

bgiuliana opened this issue Nov 8, 2023 · 4 comments · Fixed by #5691
Assignees
@tykayn
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:infra-editor Infra Edition

Comments

@bgiuliana
Copy link
Contributor

Who would benefit from this feature?

End users

What is this feature about?

  • Delete the message and the icon when the infrastructure does not contain errors and warnings
    image

Why is this feature valuable?

delete useless informations

Anything else people should know?

No response
@bgiuliana bgiuliana added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules module:infra-editor Infra Edition labels Nov 8, 2023
@sim51
Copy link
Contributor

sim51 commented Nov 20, 2023

On this, I would like to have the advise of @Tguisnet

If I do that, the UI will be the same if I enable/disable the error layout (except for error layer button), which can be weird (at least for me) . And saying that the infra is OK is an information for me, but maybe I'm wrong.

@bgiuliana bgiuliana changed the title No message and icon in an infrastructure without errors and warnings Remove message and icon when the infrastructure has no errors and warnings Nov 20, 2023
@jacomyal
Copy link
Contributor

I understand @sim51 's point. I think replacing the red by the text grey would make the information more clear and less stressful.

@sim51
Copy link
Contributor

sim51 commented Nov 20, 2023

BTW we also discussed between us to remove the transparent background of the element, I have no pros & cons on that

@tykayn tykayn mentioned this issue Nov 27, 2023
Merged
@tykayn
Copy link
Contributor

tykayn commented Dec 5, 2023

@bgiuliana i made a PR to completely hide the message saying that there is no anomaly on the infrastructure. Is it what you wanted ?

tykayn pushed a commit that referenced this issue Dec 5, 2023
@blemoineovh
front:editor: fixes #5632 after rebase on config files
89e03bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tykayn tykayn

Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:infra-editor Infra Edition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: hide error box when there is 0 issues 🐛 OpenRailAssociation/osrd
4 participants
@jacomyal @sim51 @tykayn @bgiuliana