front: fix stdcm add via scroll #10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Jan 10, 2025
front/src/applications/stdcm/components/StdcmForm/StdcmVias.tsx
Outdated
Show resolved
Hide resolved
emersion
approved these changes
Jan 10, 2025
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10324 +/- ##
==========================================
- Coverage 81.63% 81.62% -0.02%
==========================================
Files 1063 1063
Lines 105426 105432 +6
Branches 722 722
==========================================
- Hits 86060 86054 -6
- Misses 19325 19337 +12
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Focus the CI input of the new added via - Reset the state giving the via index to scroll to after the action to enable the animation even when the user adds 2 vias in a row at the same index Signed-off-by: SharglutDev <p.filimon75@gmail.com>
SharglutDev
force-pushed
the
pfn/front/fix-stdcm-add-via-scroll
branch
from
c5d6dd3 to
5e8e88c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9713 (see last comment in the issue)