Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lmr: front: rework the addition of intermediate OPs #9713

Closed
3 tasks
axrolld opened this issue Nov 14, 2024 · 2 comments · Fixed by #10024 or #10324
Closed
3 tasks

lmr: front: rework the addition of intermediate OPs #9713

axrolld opened this issue Nov 14, 2024 · 2 comments · Fixed by #10024 or #10324
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM

Comments

@axrolld
Copy link
Contributor

axrolld commented Nov 14, 2024

Description

Adding an intermediaite OP isn't clear enough for the users, we'd like to make this interaction clearer.

AC

  • There should be an automatic scroll if the card exits the view.
  • The CI field must be focus after clicking "Add an intermediaite OP"
  • The cards appear with an animation (mockup un comment below)
@axrolld axrolld added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM labels Nov 14, 2024
@thibautsailly
Copy link

Prototypes available at Sketch > Last Minute Request > Request forme > #9713 - Animating the OP addition

Here is what happens when the new OP card can be displayed in full height in the viewport:
Image

Higher definition screen capture: /~https://github.com/user-attachments/assets/4b1730ff-5f2d-46d0-ac01-2927edcafe7c
Same animation, but slowed down: /~https://github.com/user-attachments/assets/ecb1160c-c65d-4513-9ed5-cb2edcfe2a8a

Here is what happens when the new OP card cannot be displayed in full height in the viewport:
Image

Higher definition screen capture: /~https://github.com/user-attachments/assets/6cc25846-2c60-4647-bb23-ea26e35c08d2
Same animation, but slowed down: /~https://github.com/user-attachments/assets/c425fa84-2076-48b1-959b-218ba04fbc6e

@Arthur-Lefebvre
Copy link

01/09/2025 tests results :

The issue is reopenned because it doesn't fullfill all the AC.

  • There should be an automatic scroll if the card exits the view.
    This AC is partially satisfied :
  • For the first intermediate OP, the automatic scroll works properly
  • But after, if you add an intermediate OP in first position, the automatic scroll doesn't work
  • Then if you add an intermediate OP, but not the first one, it works
  • After this, it works for the first one, but only once
  • If you want the scroll for first one to work again, you have to add an intermediate OP which is not the first

See the behavior in the video below :
/~https://github.com/user-attachments/assets/af005e8d-84b3-4849-bcb6-88a102668c8b

  • The CI field must be focus after clicking "Add an intermediate OP"
    This AC is not satisfied
  • The cards appear with an animation (mockup un comment below)
    This AC is fully satisfied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features module:stdcm Short-Term DCM
Projects
None yet
4 participants