front: animate new intermediate op in stdcm #10024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10024 +/- ##
==========================================
- Coverage 79.82% 79.81% -0.02%
==========================================
Files 1054 1054
Lines 105530 105588 +58
Branches 726 726
==========================================
+ Hits 84244 84278 +34
- Misses 21244 21268 +24
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
force-pushed
the
pfn/front/rework-intermediate-op
branch
5 times, most recently
from
7a36033 to
aeecc0c
Compare
Caracol3
approved these changes
Dec 18, 2024
emersion
reviewed
Dec 19, 2024
front/src/applications/stdcm/components/StdcmForm/StdcmVias.tsx
Outdated
Show resolved
Hide resolved
emersion
reviewed
Dec 19, 2024
front/src/applications/stdcm/components/StdcmForm/StdcmVias.tsx
Outdated
Show resolved
Hide resolved
|
Maybe the commit message could be a tad more explicit? Maybe "front: animate new intermediate op in stdcm"? |
SharglutDev
force-pushed
the
pfn/front/rework-intermediate-op
branch
from
aeecc0c to
887f29a
Compare
emersion
changed the title
SharglutDev
force-pushed
the
pfn/front/rework-intermediate-op
branch
from
5f8ebdd to
be52429
Compare
- Add an animation when a new intermediate op is added - Scroll to keep it in the viewport if it overflows - Adapat e2e tests in stdcm to ensure buttons are clickable while it's animating Signed-off-by: SharglutDev <p.filimon75@gmail.com>
SharglutDev
force-pushed
the
pfn/front/rework-intermediate-op
branch
from
be52429 to
eaa4315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit description.
cubic-bezier animation has been generated here with this nice tool.
Animation behavior is already validated by @thibautsailly.
close #9713