Add PathNotFoundError in _load_convert for open_converted

[leewujung]

open_converted failed on opening Zarr file without the beam_power group. The allowed exception GroupNotFoundError appears to only work for netCDF files but not with Zarr files:

PathNotFoundError: nothing found at path 'Beam_power'

Adding PathNotFoundError resolved the problem.

I also tested the case to only use PathNotFoundError without GroupNotFoundError and that works for both local netCDF and Zarr files.

From the zarr code here
/~https://github.com/zarr-developers/zarr-python/blob/master/zarr/errors.py
GroupNotFoundError is for when "group not found at path {0!r}"
and
PathNotFoundError is for when "nothing found at path {0!r}"

@imranmaj @lsetiawan : If I understand correctly right now the beam_power group is always created regardless of the sonar_model, but may be empty. So, there will be no case with exception GroupNotFoundError. Is this correct?

The current PR replaces GroupNotFoundError with PathNotFoundError.

[lsetiawan]

If I understand correctly right now the beam_power group is always created regardless of the sonar_model, but may be empty

I don't remember if it's always created. Kavin did a lot of those group creation code, so I do not know. :/

[leewujung]

I don't remember if it's always created. Kavin did a lot of those group creation code, so I do not know. :/

Right now on initialization EchoData this is done:

echopype/echopype/echodata/echodata.py

Lines 113 to 115 in d9405a4

	def __setup_groups(self):
	for group in self.group_map.keys():
	setattr(self, group, None)

which pulls all keys in group_map created from _get_convention

echopype/echopype/echodata/echodata.py

Line 37 in d9405a4

group_map = OrderedDict(_get_convention()["groups"])

I think the latter is you 😄 , but it doesn't matter.

Unless there's anything missing in this sequence, I am pretty sure this is correct.

[leewujung]

Although, from the CI test failure, it seems that things may be handled differently on different platforms re what it means to have/no have a group, and whether there is anything in the path or group... I'll try adding GroupNotFoundError back in. If this fails, I'll have to properly set up the tests locally. 😛

[codecov-commenter]

Codecov Report

Merging #447 (19b9c50) into dev (25fe601) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #447      +/-   ##
==========================================
- Coverage   76.74%   76.64%   -0.10%     
==========================================
  Files          38        5      -33     
  Lines        3324      334    -2990     
==========================================
- Hits         2551      256    -2295     
+ Misses        773       78     -695     

Flag	Coverage Δ
unittests	76.64% <100.00%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
echopype/echodata/echodata.py	78.81% <100.00%> (-8.87%)	⬇️
echopype/preprocess/__init__.py
echopype/testing.py
echopype/convert/utils/ek_date_conversion.py
echopype/convert/parse_base.py
echopype/calibrate/__init__.py
echopype/calibrate/calibrate_azfp.py
echopype/__init__.py
echopype/calibrate/calibrate_base.py
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25fe601...19b9c50. Read the comment docs.