Correct duplicate ping_times during EK60 conversion (fixes #235) #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #433 +/- ##
==========================================
- Coverage 76.41% 70.25% -6.17%
==========================================
Files 37 22 -15
Lines 3227 2585 -642
==========================================
- Hits 2466 1816 -650
- Misses 761 769 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
From discussions with @imranmaj and @emiliom :
|
leewujung
approved these changes
Sep 23, 2021
leewujung
added a commit
that referenced
this pull request
Oct 1, 2021
* re-attach sonar_model to combined echodata object (#437) * Correct duplicate ping_times during EK60 conversion (fixes #235) (#433) * Add fix for duplicate ping_time * Remove dead code * Increment by 1ns instead of 1ms * Add duplicate ping time warning and store in provenance * Autoformatter * Add test for duplicate ping times file * Add qc method to remove duplicate pings * Drop entire pings with duplicate values * Store entire original ping_time and add attribute when there are duplicate ping_times * Remove duplicate ping_time qc method, it will be added back in future PR * Change EchoData combine ping_time reversal attribute to netCDF encodable value * Remove unused import * Update tests * Clarify duplicate ping_time removal and drop warnings * Add removal note to deprecation warnings (#443) * Add removal note to deprecation warnings * Say removal will be specifically in next release * AD2CP conversion bug fixes (#438) * Allow strings in AD2CP config string data record * Add ping_time dimension to ahrs variables * Default AHRS to empty list instead of None * Change AHRS dims when it does not exist * Add update_platform method to EchoData (#434) * Add update_platform method to EchoData * Add test for update_platform * Use drop_vars instead of drop * Use .data on variables * Generalize extra_platform_data time dimension name * Add AZFP support * Generalized update_platform handling of CF trajectory-encoded datasets * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Default water_level to zeros instead of ones * Add warning for overwritten variables * Index incoming data by time2 * Add long_name for time2 * Show dropped variable warning when nans do not exist * Reword dropped variable warning * Rename mapping_get_multiple to mapping_search_variable Co-authored-by: Emilio Mayorga <emiliomayorga@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Add summary statistics (#444) * initial add of echo metrics functions * update echo metrics to use range as data variable * small readability edit * added test functions to echopype.tests * Modified syntax for consistency * lint corrections on metrics * added docstrings * changed summary_statistics.py docstrings to numpy format * Clean up tabs in code * Clean up tabs in test code * add metrics to run-test.py * renamed test_metrics_summary_statistics * small debug edits * pre commit black edits * moved test_metrics_summary_statistics.py to /tests/metrics/ * docstring update, add typing, change inertia to dispersion * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: stuara <stuara@uw.edu> Co-authored-by: Landung "Don" Setiawan <landung.setiawan@gmail.com> Co-authored-by: stuara <83487347+stuara@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Prepare workflows for master -> main (#445) * Add PathNotFoundError in _load_convert for open_converted (#447) * add PathNotFoundError in _load_convert for open_converted Co-authored-by: imranmaj <49664304+imranmaj@users.noreply.github.com> Co-authored-by: Emilio Mayorga <emiliomayorga@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: stuara <stuara@uw.edu> Co-authored-by: Landung "Don" Setiawan <landung.setiawan@gmail.com> Co-authored-by: stuara <83487347+stuara@users.noreply.github.com> Co-authored-by: Landung "Don" Setiawan <landungs@uw.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Corrects duplicate
ping_times during EK60 conversion by incrementing duplicate times by 1ns