Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar Resource Converter macro updates for new SolarAnywhere file formats #542

Merged
merged 4 commits into from
Feb 24, 2021

Conversation

cpaulgilman
Copy link
Collaborator

Fix #491

* Replace SolarAnywhere format check for number of columns by check for "0" in first column of first row.

* Handle single-year files with less than one-year of data. For example, files for current year only have data up to current date.

* Clean up Solar Resource File Checker error mssage.

* Solar Resource UI, error message, explain to remove file from library when file with partial year data is added. I decided not to remove files with less than one year of data from library in preparation for SAM being able to run part year simulations in the future.
Show name of offending file with suggestion to remove it from weather file folders.
@cpaulgilman cpaulgilman requested a review from sjanzou February 21, 2021 23:02
@cpaulgilman
Copy link
Collaborator Author

Merging now to minimize risk of potential UI conflicts with Solar Resource.txt

@cpaulgilman cpaulgilman merged commit ce8e156 into patch Feb 24, 2021
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for the delay - everything looks good

@cpaulgilman cpaulgilman deleted the SAM491_SolarAnywhere-macro-updates branch March 1, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants