Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar Resource File Converter Macro for SolarAnywhere V3.4 Files #491

Closed
KWagnerCPR opened this issue Dec 31, 2020 · 3 comments
Closed

Solar Resource File Converter Macro for SolarAnywhere V3.4 Files #491

KWagnerCPR opened this issue Dec 31, 2020 · 3 comments
Assignees

Comments

@KWagnerCPR
Copy link

Describe the bug
SolarAnywhere V3.4 file downloads have 9 columns in the first row. This is the case when the metadata in cell H1 spills over into cell I1. The SAM solar resource file converter macro is currently designed to only accept files with 8 columns in row 1 so attempting to convert a SolarAnywhere V3.4 file breaks the macro.

To Reproduce
Steps to reproduce the behavior:

  1. Obtain a SolarAnywhere V3.4 TMY3 format or SA format file.
  2. Open a new project in SAM.
  3. In the bottom left corner, select Macros. Select Solar Resource File Converter from the list, then select SolarAnywhere from the
    Weather file format drop down in the top right corner.
  4. Select Run macro and choose your SolarAnywhere V3.4 file.

Expected behavior
I would expect the converter to successfully convert the SolarAnywhere format file to a samcsv format file as it has in the past when converting SolarAnywhere V3.3 files. But instead you receive an error saying the file does not appear to be in SolarAnywhere format.

Screenshots

image

Operating System and Version

  • OS: Windows
  • Version: SAM 2020.11.29

Additional context
Add any other context about the problem here.

@cpaulgilman
Copy link
Collaborator

@KWagnerCPR, would you mind attaching an example of a file in the both the TMY3 and SA format generated by SolarAnywhere V3.4 that we can use as a basis for updating the macro?

@cpaulgilman cpaulgilman self-assigned this Feb 18, 2021
@KWagnerCPR
Copy link
Author

@cpaulgilman Sure thing! I'm going to email you examples of a time series, TGY, and TDY files in both TMY3 and SolarAnywhere output formats. We also provide probability of exceedance files in both formats. Do you need examples of those? The header information in cell H1 would be slightly different.

@cpaulgilman
Copy link
Collaborator

Sample files for testing:

SolarAnywhere_SA_and_TMY3 format_examples.zip

@cpaulgilman cpaulgilman added this to the 2020.11.29 Patch 1 milestone Feb 21, 2021
cpaulgilman added a commit that referenced this issue Feb 21, 2021
* Replace SolarAnywhere format check for number of columns by check for "0" in first column of first row.

* Handle single-year files with less than one-year of data. For example, files for current year only have data up to current date.

* Clean up Solar Resource File Checker error mssage.

* Solar Resource UI, error message, explain to remove file from library when file with partial year data is added. I decided not to remove files with less than one year of data from library in preparation for SAM being able to run part year simulations in the future.
cpaulgilman added a commit that referenced this issue Feb 24, 2021
…mats (#542)

* Fix #491 Solar Resource Converter macro for new SolarAnywhere format

* Replace SolarAnywhere format check for number of columns by check for "0" in first column of first row.

* Handle single-year files with less than one-year of data. For example, files for current year only have data up to current date.

* Clean up Solar Resource File Checker error mssage.

* Solar Resource UI, error message, explain to remove file from library when file with partial year data is added. I decided not to remove files with less than one year of data from library in preparation for SAM being able to run part year simulations in the future.

* Resolve Solar Resource Data.txt merge conflict with patch

* Solar Resource UI message when weather file reader fails

Show name of offending file with suggestion to remove it from weather file folders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants