Add support for PDT 4.32 and change PDT class structure #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit provides support for PDT 4.32. This is the first PDT that deviates from the "base" structure of PDT 0. In 4.32, the fixed surface attributes are not present. Therefore, need to remove section 4 attrs from the Grib2Message class and define elsewhere. The solution provided here is to create 2 new PDT-related template classes as "base" classes. These are ProductDefinitionTemplateBase and ProductDefinitionTemplateSurface and they can be inherited by the actual PDT classes. Also here is a change to the wgrib2-formatted level string to provide the string 'no_level'. This commit references #128
Added satellite band attributes for when numberOfContributingSpectralBands is greater than 0.
PDTN 4.31 is similar to 4.32 Syntax clean up for class definitions This commit references issue #128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides support for PDT 4.32.
This is the first PDT that deviates from the "base" structure of PDT 0. In 4.32, the fixed surface attributes are not present. Therefore, need to remove section 4 attrs from the Grib2Message class and define elsewhere.
The solution provided here is to create 2 new PDT-related template classes as "base" classes. These are ProductDefinitionTemplateBase and ProductDefinitionTemplateSurface and they can be inherited by the actual PDT classes.
Also here is a change to the wgrib2-formatted level string to provide the string 'no_level'.
This commit references #128