Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PDT 4.32 #128

Closed
EricEngle-NOAA opened this issue Jan 23, 2024 · 0 comments · Fixed by #130
Closed

Add support for PDT 4.32 #128

EricEngle-NOAA opened this issue Jan 23, 2024 · 0 comments · Fixed by #130
Assignees
Labels
enhancement New feature or request

Comments

@EricEngle-NOAA
Copy link
Collaborator

Add support for PDT 4.32 - Analysis or Forecast at a horizontal level or in a horizontal layer at a point in time for simulated (synthetic) satellite data

This PDT is support in NCEPLIBS-g2c

@EricEngle-NOAA EricEngle-NOAA added the enhancement New feature or request label Jan 23, 2024
@EricEngle-NOAA EricEngle-NOAA added this to the grib2io v2.2 milestone Jan 23, 2024
@EricEngle-NOAA EricEngle-NOAA self-assigned this Jan 23, 2024
EricEngle-NOAA added a commit that referenced this issue Jan 24, 2024
This commit provides support for PDT 4.32.

This is the first PDT that deviates from the "base" structure of
PDT 0.  In 4.32, the fixed surface attributes are not present.
Therefore, need to remove section 4 attrs from the Grib2Message class
and define elsewhere.

The solution provided here is to create 2 new PDT-related template
classes as "base" classes.  These are ProductDefinitionTemplateBase and
ProductDefinitionTemplateSurface and they can be inherited by the actual
PDT classes.

Also here is a change to the wgrib2-formatted level string to provide
the string 'no_level'.

This commit references #128
EricEngle-NOAA added a commit that referenced this issue Jan 29, 2024
PDTN 4.31 is similar to 4.32

Syntax clean up for class definitions

This commit references issue #128
EricEngle-NOAA added a commit that referenced this issue Jan 29, 2024
* Add support for PDT 4.32 and change PDT class structure

This commit provides support for PDT 4.32.

This is the first PDT that deviates from the "base" structure of
PDT 0.  In 4.32, the fixed surface attributes are not present.
Therefore, need to remove section 4 attrs from the Grib2Message class
and define elsewhere.

The solution provided here is to create 2 new PDT-related template
classes as "base" classes.  These are ProductDefinitionTemplateBase and
ProductDefinitionTemplateSurface and they can be inherited by the actual
PDT classes.

Also here is a change to the wgrib2-formatted level string to provide
the string 'no_level'.

This commit references #128

* Update for attrs for PDT 4.32

Added satellite band attributes for when numberOfContributingSpectralBands is greater than 0.

* Add support for PDTN 4.31

PDTN 4.31 is similar to 4.32

Syntax clean up for class definitions

This commit references issue #128

---------

Co-authored-by: Eric Engle <EricEngle-NOAA@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant