Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar event card scroll overflow #171

Merged
merged 7 commits into from
Feb 18, 2023

Conversation

Xanonymous-GitHub
Copy link
Member

@Xanonymous-GitHub Xanonymous-GitHub commented Feb 18, 2023

Description

In #154, the new-refactored calendar seems still has some problems.

  • The event tile of calendar may be able to scroll overflow, which overlapped the calendar section.
  • The event of any day maybe duplicate because the school server can't respond an accurate range of events. For example, if the given event range is 01/01 ~ 01/31, the server may respond events between 12/xx ~ 02/xx (not constantly).

So in this PR,

  • make the event card disappeared when scroll over. (by using the Card widget)
  • we tried to prevent the event not in expected scope been added into the list while creating calendar.

How to Verify?

For the UI problem (prefer validating in iOS):

  1. go to calendar page
  2. choose a day which contains some events and click it
  3. scroll the event list (toward top), check if the overflowed event cards are not overlapped the calendar section.

For the event duplicate problem:

  1. go to calendar page
  2. see 2023/02/20 events, there should be four events.
  3. swipe to 2023/03's calendar, after it loaded, swipe back to 2023/02
  4. check if 2023/02/20 still has four events.

Screenshots/GIF/Test Results (Optional)

@Xanonymous-GitHub Xanonymous-GitHub added the type: bug Something isn't working label Feb 18, 2023
@Xanonymous-GitHub Xanonymous-GitHub added this to the 1.4.3 milestone Feb 18, 2023
@Xanonymous-GitHub Xanonymous-GitHub self-assigned this Feb 18, 2023
@Xanonymous-GitHub Xanonymous-GitHub marked this pull request as draft February 18, 2023 13:33
@Xanonymous-GitHub Xanonymous-GitHub force-pushed the fix-calendar-event-card-scroll-overflow branch from a8c43fe to 797a3ab Compare February 18, 2023 13:50
@Xanonymous-GitHub Xanonymous-GitHub marked this pull request as ready for review February 18, 2023 13:52
Copy link
Collaborator

@ricky9667 ricky9667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Xanonymous-GitHub Xanonymous-GitHub merged commit 30c03f8 into master Feb 18, 2023
@Xanonymous-GitHub Xanonymous-GitHub deleted the fix-calendar-event-card-scroll-overflow branch February 18, 2023 14:27
Xanonymous-GitHub added a commit that referenced this pull request Mar 28, 2023
* refactor: remove unused functions in AppProvider

* refactor: remove navigator key reassign

* feat: wrap event card in Card widget

* fix: dulplicated calendar events

* fix: missing default task error dialog type

* fix: colorScheme from AppProvider can not been updated while changing sys's color style

* format: remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants