Refactor Calendar page & Pump flutter version to 3.3.10 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanonymous-GitHub
changed the title
Xanonymous-GitHub
changed the title
ricky9667
reviewed
Dec 30, 2022
Xanonymous-GitHub
added a commit
that referenced
this pull request
Mar 28, 2023
* chore: upgrade packages * chore: replace alice with alice_lightweight * chore: remove strange comments * chore: remove strange comments * feat: rewrite Calendar page with new Calendar controller * refactor: migrate language util to null safety * refactor: reconfig calendar style * fix: calendar event box ripper effect overflow box * fix: prevent calendar focus day reset while it has already sotred any data of a month * chore: upgrade kotlin version * chore: upgrade ios plugin version * chore: upgrade packages * refactor: update Awsome Dialog type to fit the new plugin version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade all dependencies and flutter sdk version to
3.3.10.The Android Kotlin version has upgraded to
1.8.0.There are three breaking changes:
The dependency version has upgraded to v3, which deprecated the origin
DialogTylevalues.These update changes has addressed here: 3a0d35a.
Since the
alicepackage onpub.devdepends on lots of its sub-packages which makes us hard to maintain TAT's dependency versions, we have migrated it to thealice_lightweightpackage.Through the
table_calendarpackage version has been upgraded to v3, we rebuilt the whole calendar page.First, a new
CalendarController, which extendsGetXController, has been created. We moved all non-UI layer functions and variables into this controller, and wrapped the calendar and calendar event list view widget byGetBuilderfor receiving state updates from the controller.Then, we introduced a cache mechanism for the calendar data, which makes it not needed to re-fetch data while it has already exist.
Additionally, the calendar style has also been refactored. You may found the event marker style changed, and the ripple effect of event ListTile has been fixed that it will not overflow of its container now.
In addition, the comments in the
pubspec.ymlfile has been removed now, since they didn't express any useful meanings and make the file looks so messy.How to Verify?
week,two weekischool page.Dio LogpageScreenshots/GIF/Test Results (Optional)