Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

(1) Replace 'lidvid' with 'identifier', (2) 'latest' and 'all' APIs #76

Merged
merged 6 commits into from
Oct 7, 2021

Conversation

tdddblog
Copy link
Contributor

@tdddblog tdddblog commented Oct 2, 2021

🗒️ Summary

(1) Replace 'lidvid' with 'identifier'
(2) 'latest' and 'all' APIs - implemented

  • collections_of_a_bundle_all (bundle/{lidvid}/collections/all)
  • collections_of_a_bundle_latest (bundle/{lidvid}/collections/latest)
  • products_of_a_collection_all (collection/{lidvid}/products/all)

(3) 'latest' and 'all' APIs - added the API, but it returns the same results as collection/{lidvid}/products/all

  • products_of_a_collection_latest (collection/{lidvid}/products/latest)

See NASA-PDS/pds-api#108 and NASA-PDS/pds-api#115

⚙️ Build Instructions

  • Build and install pds-api-javalib project from swaggerhub-pds_federated_api-pds-api-115 branch (mvn install)
  • Then build this (registry-api-service) project

@tdddblog tdddblog requested a review from a team as a code owner October 2, 2021 18:03
Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That lloks good, thanks Eugene.

I had a question for something I did not check:
for end point /bundles/{lid}/collections/all

if we have multiple bundle versions for this lid, then would we get all the collections which belongs to all the bundle's version ? I believe that is what we should do for the readibility of the API behavior but if it does not yet, this is no a big deal.

@tloubrieu-jpl tloubrieu-jpl merged commit d78d810 into main Oct 7, 2021
@tdddblog
Copy link
Contributor Author

tdddblog commented Oct 7, 2021

As we discussed in one of our breakout meetings, we get the latest version of a bundle and then all versions of collections for that single bundle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants