[7430] FE - current events slider #7505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevedya
changed the title
stevedya
force-pushed
the
feature/7430-current-events-slider-fe
branch
from
5195a8e to
86ebcac
Compare
stevedya
changed the base branch from
feature/be-fe-mozfest-current-events-slider
to
feature/7431-be-mozfest-current-events-slider
Base automatically changed from
feature/7431-be-mozfest-current-events-slider
to
feature/be-fe-mozfest-current-events-slider
October 5, 2021 16:19
janehughes
approved these changes
Oct 5, 2021
network-api/networkapi/mozfest/templates/fragments/carousel/carousel_navigation.html
Show resolved
Hide resolved
stevedya
changed the title
Co-authored-by: janehughes <janeelizabethhughes@gmail.com>
b-ggs
pushed a commit
that referenced
this pull request
Oct 6, 2021
* Current events slider styles * Install swiper and style event cards * Break slider out of container * Adjust spacing and containers for wide templates and signup sidebar * Merge FE on to BE * Update source/sass/mozfest.scss Co-authored-by: janehughes <janeelizabethhughes@gmail.com> Co-authored-by: janehughes <janeelizabethhughes@gmail.com>
stevedya
added a commit
that referenced
this pull request
Oct 21, 2021
* Current events slider styles * Install swiper and style event cards * Break slider out of container * Adjust spacing and containers for wide templates and signup sidebar * Merge FE on to BE * Update source/sass/mozfest.scss Co-authored-by: janehughes <janeelizabethhughes@gmail.com> Co-authored-by: janehughes <janeelizabethhughes@gmail.com>
Pomax
added a commit
that referenced
this pull request
Nov 4, 2021
* Add common reusable link blocks * BE: Mozfest Spaces Cards * [7430] FE - current events slider (#7505) * Current events slider styles * Install swiper and style event cards * Break slider out of container * Adjust spacing and containers for wide templates and signup sidebar * Merge FE on to BE * Update source/sass/mozfest.scss Co-authored-by: janehughes <janeelizabethhughes@gmail.com> Co-authored-by: janehughes <janeelizabethhughes@gmail.com> * Update template size condition * Grid adjustment depending on signup form being visible * Javascript cleanups as per code review * Update migrations * Make subheading_link optional * Carousel alignment fixes * Carousel full width * Signup form placement depending on which block is rendered in base * Add property to event block to check if wide * Add template tag for holding singup form boolean to render form * Js modifications as per feedback * Remove base page overrides for overflowing sliders, configure slider to show 2 cards on desktop * autoheight for carousels on mozfest * Fix flake issues * Fix eslint issues * Remove newline * Use double-quotes in tailwind config #7457 (comment) * Use template literal in querySelector /~https://github.com/mozilla/foundation.mozilla.org/pull/7457/files#r733242084 * Use forEach instead of for, use template literal for querySelectorAll /~https://github.com/mozilla/foundation.mozilla.org/pull/7457/files#r733241307 * Use single quotes #7457 (comment) * Remove unused load in mozfest-base * Remove unused template tag that was used in development * Remove empty carousel.scss * Remove duplicated class and fix nav title not showing with current events length * Remove commented out overlay * Switch colors to originally intended colors * Remove space changes * Update migrations * Replace ListBlock with StreamBlock * Remove rogue spacing changes * More rogue space changes * Minor spacing changes * Remove duplicate styles * Add padding to h2 * Remove newline change * Move navigation buttons into slider main container * Change title font weight to 600 #7457 (review) * Update subheading color to tw-text-blue (#595cf3) #7457 (review) * Remove fill-rule and clip-rule from carousel_navigation fragment #7515 (comment) * Use blocks instead of comments in block template #7515 (comment) * Update migrations * Remove tailwind config changes * Change mobile navigation active bullet color to #0d10bf #7457 (review) * Update migrations Co-authored-by: Steve Stein <steven_ts@hotmail.com> Co-authored-by: janehughes <janeelizabethhughes@gmail.com> Co-authored-by: Pomax <pomax@nihongoresources.com>
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch with testing data until the BE is ready for integration.
Closes #7430
Related PRs/issues #
Link to sample test page:
Checklist
Remove unnecessary checks
Tests
Documentation: