Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE/FE] Mozfest Current Events Slider #7457

Merged
merged 57 commits into from
Nov 4, 2021
Merged

[BE/FE] Mozfest Current Events Slider #7457

merged 57 commits into from
Nov 4, 2021

Conversation

b-ggs
Copy link
Collaborator

@b-ggs b-ggs commented Sep 23, 2021 •
edited
Loading

Related PRs/issues #7429

Checklist

  • Did I squash my migration?

Screenshots:

Wagtail Admin:
Screen Shot 2021-10-07 at 5 45 51 AM

UI:
Screen Shot 2021-10-07 at 5 46 06 AM

@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-mclwyx September 23, 2021 12:54 Inactive
@wilhitem wilhitem added this to the MozFest 2021 TBX milestone Sep 28, 2021
@stevedya stevedya requested review from Pomax and sabrinang October 5, 2021 17:26
@stevedya stevedya marked this pull request as ready for review October 5, 2021 17:32
sabrinang
sabrinang requested changes Oct 6, 2021
View reviewed changes
Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes to see if it this makes the deployment active again

boggs and others added 5 commits October 7, 2021 04:37
Add common reusable link blocks
6d40c69
BE: Mozfest Spaces Cards
8776fcd
@stevedya @janehughes
[7430] FE - current events slider (#7505)
7bf3e17 
* Current events slider styles

* Install swiper and style event cards

* Break slider out of container

* Adjust spacing and containers for wide templates and signup sidebar

* Merge FE on to BE

* Update source/sass/mozfest.scss

Co-authored-by: janehughes <janeelizabethhughes@gmail.com>

Co-authored-by: janehughes <janeelizabethhughes@gmail.com>
@stevedya
Update template size condition
569228b
@stevedya
Grid adjustment depending on signup form being visible
577d28a
@b-ggs b-ggs force-pushed the feature/be-fe-mozfest-current-events-slider branch from 6716938 to 577d28a Compare October 6, 2021 20:49
@Pomax Pomax temporarily deployed to foundation-s-feature-be-fdo5h8 October 6, 2021 21:06 Inactive
@sabrinang sabrinang self-requested a review October 7, 2021 20:24
sabrinang
sabrinang requested changes Oct 7, 2021
View reviewed changes
Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type

  • Subheading link: follow .body size (18px/27px)

Layout

  • the left side of the slider crops/hides the content on tablet/desktop viewports, if the right breaks out of the container area the left should be seen too

image

  • if there is only one event item, can the arrows be hidden? (looks good on mobile where the indicator isn't present)

image

CMS
This might be content related but will there always be a subheading link because that field is required. It might be nice for that to be optional in case there isn't a "working group" link

Pomax
Pomax suggested changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few notes and questions

network-api/networkapi/mozfest/templates/mozfest/mozfest-base.html Outdated Show resolved Hide resolved
network-api/networkapi/wagtailpages/pagemodels/customblocks/common/link_blocks.py Outdated Show resolved Hide resolved
source/js/components/carousel/carousel.js Outdated Show resolved Hide resolved
source/js/main.js Outdated Show resolved Hide resolved
source/js/main.js Outdated Show resolved Hide resolved
source/sass/main.scss Outdated Show resolved Hide resolved
source/js/components/carousel/carousel.js Outdated Show resolved Hide resolved
@sabrinang sabrinang mentioned this pull request Oct 7, 2021
Closed
@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 8, 2021 22:56 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 11, 2021 15:26 Inactive
@b-ggs
Copy link
Collaborator Author

b-ggs commented Oct 11, 2021

Subheading links are now not required.

Screen Shot 2021-10-11 at 11 25 48 PM

I've also rebased from main and updated the migrations.

@b-ggs b-ggs requested review from Pomax and sabrinang October 11, 2021 15:28
@b-ggs
Copy link
Collaborator Author

b-ggs commented Oct 11, 2021

This is still pending frontend-related updates

@sabrinang sabrinang mentioned this pull request Oct 27, 2021
Merged
7 tasks
@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 27, 2021 16:06 Inactive
@b-ggs
Copy link
Collaborator Author

b-ggs commented Oct 27, 2021

Thanks @sabrinang! Fixed the bullet color here: 9d06453

Screen Shot 2021-10-28 at 12 06 10 AM

@b-ggs b-ggs requested a review from sabrinang October 27, 2021 16:07
Pomax
Pomax reviewed Oct 27, 2021
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pomax
Pomax approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookgs good to me =)

@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

sabrinang
sabrinang approved these changes Oct 27, 2021
View reviewed changes
Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great thank you for updating!

@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 27, 2021 20:31 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 29, 2021 09:08 Inactive
@b-ggs
Copy link
Collaborator Author

b-ggs commented Oct 29, 2021

The migration in this PR has been renumbered to 0025 in 6c49765!

@mofodevops mofodevops temporarily deployed to foundation-s-feature-be-fdo5h8 October 29, 2021 09:10 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

1 similar comment
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@Pomax Pomax temporarily deployed to foundation-s-feature-be-fdo5h8 November 4, 2021 14:53 Inactive
@Pomax Pomax merged commit 4fb1895 into main Nov 4, 2021
@Pomax Pomax deleted the feature/be-fe-mozfest-current-events-slider branch November 4, 2021 14:54
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@sabrinang sabrinang mentioned this pull request Feb 7, 2022
Closed
@tbrlpld tbrlpld mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedya stevedya stevedya left review comments

@sabrinang sabrinang sabrinang approved these changes

@Pomax Pomax Pomax approved these changes

Assignees

@Pomax Pomax

@sabrinang sabrinang

Labels
None yet
Projects
None yet
Milestone
MozFest 2021 TBX
Development

Successfully merging this pull request may close these issues.
6 participants
@b-ggs @stevedya @Pomax @sabrinang @wilhitem @mofodevops