Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FastPR][Hotfix][Fluid] Navier-Stokes wall condition DOF position hotfix #12335

Merged

Conversation

rubenzorrilla
Copy link
Member

📝 Description
Hotfix in the NavierStokesWallCondition DOF position.

@rubenzorrilla rubenzorrilla added Applications Hotfix FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Apr 30, 2024
@rubenzorrilla rubenzorrilla self-assigned this Apr 30, 2024
@rubenzorrilla rubenzorrilla requested a review from a team as a code owner April 30, 2024 17:00
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, was this wall condition working until now? Thanks @rubenzorrilla :)

@rubenzorrilla
Copy link
Member Author

Wow, was this wall condition working until now? Thanks @rubenzorrilla :)

It was but as far as I understand we were not taking any advantage of providing the (wrong) DOF position.

@rubenzorrilla rubenzorrilla merged commit 2bbc87f into master May 5, 2024
11 checks passed
@rubenzorrilla rubenzorrilla deleted the fluid/navier-stokes-wall-condition-eq-id-hotfix branch May 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications FastPR This Pr is simple and / or has been already tested and the revision should be fast Hotfix
Development

Successfully merging this pull request may close these issues.

2 participants