-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluid] Div-stable P2P1 element #12331
Conversation
…iv-stable-element-p2-p1
…stable-element-p2-p1
…stable-element-p2-p1
… into fluid/div-stable-element-p2-p1
… into fluid/div-stable-element-p2-p1
…ratosMultiphysics/Kratos into fluid/div-stable-element-p2-p1
@rubenzorrilla Just out of curiosity: I thought that the advantage of this element is that you do not need to add all the stabilization terms, but it seems that is not the case here, is there any reason for this? did you try it without any pressure stabilization? |
You're right, pressure stabilization is not strictly needed in here as this interpolation pair is LBB compliant. Indeed, I tried both with and without and works in both cases. However, it is known to behave better if the pressure subscale is added (that's why I chose this as default option). |
Any good samaritan willing to have a look to this? |
applications/FluidDynamicsApplication/custom_conditions/navier_stokes_wall_condition.cpp
Outdated
Show resolved
Hide resolved
Remember to merge KratosMultiphysics/GiDInterface#971 after |
Sure! Thanks for the reminder in any case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks in good shape to me
📝 Description
This PR adds a P2P1 element (together with its corresponding condition). The automatic differentiation files for generating the element are added as well. Regarding the condition, I should note that the drag calculation, the pure slip correction contribution and the wall laws support are left for a future implementation as these require a bit more intricate developments for which we don't have resources to put on at the moment.
Besides, an auxiliary function to postprocess the edges' midpoint nodes pressure has been also added (note that this is called at the end of the
SolveSolutionStep
considering that current element can be used in an outer nonlinear loop). This function works with both OpenMP and MPI parallelism.Subsequent PRs will make this element available in the GiD and FlowGraph GUIs and add a use case to the examples repository.