Getting n_distinct working for summaries #9248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdstern the change is now a little bigger. This did not work for factors but that is now fixed. |
rdstern
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
@lilyclements nice, and thanks and I'm getting encourages we are now fixing these rare problems.
@N-thony please can you check and merge. This will not be your most difficult task this week!
N-thony
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rdstern the smallest change I think I've ever done in a PR (which is very pleasant!). This is ready to review.
As mentioned in issue #9241, there was an error in
n_distinct. This should fix that and means it now runs fine.