Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes in our summary dialogs #9241

Closed
rdstern opened this issue Nov 9, 2024 · 5 comments · Fixed by #9250
Closed

Small changes in our summary dialogs #9241

rdstern opened this issue Nov 9, 2024 · 5 comments · Fixed by #9250

Comments

@rdstern
Copy link
Collaborator

rdstern commented Nov 9, 2024

@N-thony this should be easy for anyone:

a) In the Prepare > Reshape Data > Summarise > Subdialog we now only tick N-non Missing and Sum as the default. That seems sensible. Nothing to change. In the Describe > Tables > Summarise the default is the mean. I like that too. Nothing to change.
b) But in the Climatic > Prepare > Summarise we still (by default) tick the N-Total as well. Please not. Let's make it consistent with the Prepare > Reshape Data > Summarise.
c) A more important one now. The name (in each case) of the summary is count_non-missing_tmax, etc. This is too long and a pain both in a data frame, and now in the tables. And we use it often. The N-total, that we hardly use, is called count, which is much better.
I suggest we call the count_non_misssing count instead. Than perhaps call the N-total count_all. Or we could be even shorter and have n and n_all. @lilyclements and @N-thony what do you think?
Let's also change count_missing to count_miss, or n_miss?

I like the percentiles. They are called p75_tmax, etc.

@lilyclements
Copy link
Contributor

@rdstern happy for us to rename these variables. I agree they are quite long as it is!

@rdstern
Copy link
Collaborator Author

rdstern commented Nov 11, 2024

@lilyclements would you prefer count and count_all and count_miss, or n and n_all and n_miss? Or something else?

@lilyclements
Copy link
Contributor

@rdstern I think count is good - especially since in R they're now using count() as a function instead of summarise(n()) (although the column in R is called n by default - so I'm not against n at all).
What do you think?

@N-thony
Copy link
Collaborator

N-thony commented Nov 12, 2024

@derekagorhom can you make the change?

@rdstern
Copy link
Collaborator Author

rdstern commented Nov 12, 2024

@derekagorhom can you change the current count_non_missing_name into count_name.
Then the current count (which comed from N-total into count_all_name
And count_missing_name, into count_miss_name.

Then @lilyclements I just found a bug, from dplyr, in N-distinct - it gives an error. Could you help, so @derekagorhom corrects that at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants