Redone the changes made in PR #7894 which reversed by PR #7924 #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated br adding_data_type7493
|
@lloyddewit this seems fine now. |
lloyddewit
requested changes
Feb 6, 2023
| columnHeader.strTypeShortCode = "(S)" | ||
| ' Structured columns or Bigq or Bigz e.g. "circular" are coded with "(S)" | ||
| ElseIf strHeaderType.Contains("circular") OrElse strHeaderType.Contains("bigz") OrElse | ||
| strHeaderType.Contains("bigq") Then |
There was a problem hiding this comment.
should we set columnHeader.strTypeShortCode?
Suggested change
| strHeaderType.Contains("bigq") Then | |
| strHeaderType.Contains("bigq") Then | |
| columnHeader.strTypeShortCode = "(S)" |
lloyddewit
approved these changes
Feb 6, 2023
|
@N-thony Thank you, looks good. @berylwaswa If you can test/approve, then we can merge, thanks |
|
Okay, let me look at it.
Kind Regards,
Beryl Waswa.
…On Mon, Feb 6, 2023 at 2:47 PM lloyddewit ***@***.***> wrote:
@N-thony </~https://github.com/N-thony> Thank you, looks good.
@berylwaswa </~https://github.com/berylwaswa> If you can test/approve, then
we can merge, thanks
—
Reply to this email directly, view it on GitHub
<#8101 (comment)>,
or unsubscribe
</~https://github.com/notifications/unsubscribe-auth/AG2L3NCE7IHW7LANBVLT4M3WWDQGHANCNFSM6AAAAAAUSPKKIY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
berylwaswa
approved these changes
Feb 6, 2023
lloyddewit
added
the
skip-releasenotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR request contains changes made in PR #7894 which was merged but reversed by PR #7924.
@lloyddewit we can merge this if everything is okay.