Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made variables of class bigz or bigq to type S in the data view #7894

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Sep 26, 2022

Fixes (partially) #7493
@rdstern please have a look. Thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@lloyddewit lloyddewit added feature skip-releasenotes PRs that don't affect functionality and should not be included in the release notes and removed feature labels Oct 6, 2022
@lloyddewit
Copy link
Contributor

@N-thony Thank you for the change.
I don't think that the PR title will mean anything to the user (in any case I didn't understand it!). So I assume this PR is an internal change that should not be in the release notes.
If you think this PR should be in the release notes, then please propose a user-understandable PR title.
Thanks

@N-thony
Copy link
Collaborator Author

N-thony commented Feb 6, 2023

Hi @ChrisMarsh82 @lloyddewit this PR was merged Oct 6, 2022 but unfortunately the changes made here are not in the merged version. What could be the issue?

@lloyddewit
Copy link
Contributor

Hi @ChrisMarsh82 @lloyddewit this PR was merged Oct 6, 2022 but unfortunately the changes made here are not in the merged version. What could be the issue?

@N-thony Thank you for spotting this.
I investigated. On 21 Oct, we merged PR #7924 which reversed the changes in this PR. This was an oversight, I don't think it was deliberate. It probably happened because PR #7924 replaced an older PR which was likely branched before PR #7894 was merged.

I suggest that we make a new PR and remerge these changes. What do you think?
thanks

@N-thony
Copy link
Collaborator Author

N-thony commented Feb 6, 2023

Hi @ChrisMarsh82 @lloyddewit this PR was merged Oct 6, 2022 but unfortunately the changes made here are not in the merged version. What could be the issue?

@N-thony Thank you for spotting this. I investigated. On 21 Oct, we merged PR #7924 which reversed the changes in this PR. This was an oversight, I don't think it was deliberate. It probably happened because PR #7924 replaced an older PR which was likely branched before PR #7894 was merged.

I suggest that we make a new PR and remerge these changes. What do you think? thanks

@lloyddewit thanks for your investigation, I will open a new PR with these changes.

lloyddewit added a commit that referenced this pull request Feb 7, 2023
Redone the changes made in PR #7894 which reversed by PR #7924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-releasenotes PRs that don't affect functionality and should not be included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants