Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Oyt/private #70

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Oyt/private #70

merged 1 commit into from
Jan 23, 2019

Conversation

cloudinertia
Copy link
Contributor

@cloudinertia cloudinertia commented Jan 22, 2019 •
edited by JhChoy
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

only supports MNEMONIC

Issue Number: #61

What is the new behavior?

now vvisp support PRIVATE_KEY instead of MNEMONIC

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

coveralls commented Jan 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 243

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.0%) to 89.767%
Files with Coverage Reduction New Missed Lines %
scripts/console.js 23 100.0%
Totals Coverage Status
Change from base Build 239: 1.0%
Covered Lines: 722
Relevant Lines: 790
💛 - Coveralls

@cloudinertia cloudinertia requested review from JhChoy and junbeomlee and removed request for JhChoy January 22, 2019 15:34
@JhChoy JhChoy added enhancement New feature or request utils About vvisp-utils config About config files(service.vvisp.json, state.vvisp.json, .env etc) labels Jan 22, 2019
@JhChoy JhChoy added this to the vvisp v1.0.0 milestone Jan 22, 2019
@cloudinertia cloudinertia requested a review from JhChoy January 23, 2019 05:03
JhChoy
JhChoy reviewed Jan 23, 2019
View reviewed changes
junbeomlee
junbeomlee approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@junbeomlee junbeomlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JhChoy JhChoy self-assigned this Jan 23, 2019
@JhChoy JhChoy merged commit d82fa60 into dev Jan 23, 2019
@JhChoy JhChoy deleted the oyt/private branch January 23, 2019 07:53
@JhChoy JhChoy mentioned this pull request Jan 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JhChoy JhChoy JhChoy left review comments

@junbeomlee junbeomlee junbeomlee approved these changes

Assignees

@JhChoy JhChoy

Labels
config About config files(service.vvisp.json, state.vvisp.json, .env etc) enhancement New feature or request utils About vvisp-utils
Projects
None yet
Milestone
vvisp v1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cloudinertia @coveralls @junbeomlee @JhChoy