Skip to content
This repository has been archived by the owner on Apr 18, 2021. It is now read-only.

Allow to set private key instead of mnemonic words in .env #61

Closed
JhChoy opened this issue Jan 18, 2019 · 1 comment
Closed

Allow to set private key instead of mnemonic words in .env #61

JhChoy opened this issue Jan 18, 2019 · 1 comment
Assignees
@cloudinertia
Labels
config About config files(service.vvisp.json, state.vvisp.json, .env etc) enhancement New feature or request utils About vvisp-utils
Milestone
vvisp v1.0.0

Comments

@JhChoy
Copy link
Contributor

JhChoy commented Jan 18, 2019

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

Only mnemonic words and key index are allowed.

Expected behavior

At .env we can add

PRIVATE_KEY= 'key'

Minimal reproduction of the problem with instructions

Considering conflicts of mnemonic and private key

What is the motivation / use case for changing the behavior?

Environment


vvisp version: v0.1.11


Environment:
- Node version: 10.15.0
- Operating system: Mac OSX
@JhChoy JhChoy added enhancement New feature or request utils About vvisp-utils config About config files(service.vvisp.json, state.vvisp.json, .env etc) labels Jan 18, 2019
@JhChoy JhChoy added this to the vvisp v1.0.0 milestone Jan 18, 2019
cloudinertia added a commit that referenced this issue Jan 22, 2019
@cloudinertia
feat: #61 Allow to set private key
e0fc97b
cloudinertia added a commit that referenced this issue Jan 22, 2019
@cloudinertia
feat: #61 Allow to set private key (+2 squashed commits)
b7afb30 
Squashed commits:
[eec7b80] fix: fix test error fs.remove => fs.removeSync, make mock env setter
[e0fc97b] feat: #61 Allow to set private key
@cloudinertia cloudinertia mentioned this issue Jan 22, 2019
Merged
14 tasks
cloudinertia pushed a commit that referenced this issue Jan 22, 2019
@JhChoy @cloudinertia
feat: #61 Allow to set private key
813523f
cloudinertia pushed a commit that referenced this issue Jan 23, 2019
@JhChoy @cloudinertia
feat: #61 Allow to set private key
b9c3774
cloudinertia pushed a commit that referenced this issue Jan 23, 2019
@JhChoy @cloudinertia
feat: #61 Allow to set private key
bb763a6
cloudinertia pushed a commit that referenced this issue Jan 23, 2019
@JhChoy @cloudinertia
feat: #61 Allow to set private key
6dd30c8
cloudinertia added a commit that referenced this issue Jan 23, 2019
@cloudinertia
feat: #61 Allow to set private key
ea85ddf
cloudinertia pushed a commit that referenced this issue Jan 23, 2019
@JhChoy @cloudinertia
feat: #61 Allow to set private key
1dafe57
cloudinertia pushed a commit that referenced this issue Jan 23, 2019
@JhChoy @cloudinertia
feat: #61 Allow to set private key
2f8637d
cloudinertia pushed a commit that referenced this issue Jan 23, 2019
@JhChoy @cloudinertia
feat: #61 Allow to set private key
f2f1e82
JhChoy added a commit that referenced this issue Jan 23, 2019
@JhChoy
feat: #61 Allow to set private key
d82fa60
@JhChoy
Copy link
Contributor Author

JhChoy commented Jan 23, 2019

Closed with #70

@JhChoy JhChoy closed this as completed Jan 23, 2019
cloudinertia added a commit that referenced this issue Jan 23, 2019
@cloudinertia
feat: #61 Allow to set private key
bf34413
junbeomlee pushed a commit that referenced this issue Jan 23, 2019
@cloudinertia @junbeomlee
feat: #61 Allow to set private key
5d5aa69
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cloudinertia cloudinertia

Labels
config About config files(service.vvisp.json, state.vvisp.json, .env etc) enhancement New feature or request utils About vvisp-utils
Projects
None yet
Milestone
vvisp v1.0.0
Development

No branches or pull requests
2 participants
@cloudinertia @JhChoy