Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple queued TPA requests #3801

Merged
merged 85 commits into from
Dec 4, 2021

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Nov 30, 2020

This PR adds support for players to receive multiple teleport requests, which are queued and can be managed independently of one another.

All commands should retain their current behavior but have some new additions;

  • /tpaccept: now allows you to specify a player or * to accept a specific player's or all players' teleport request(s) respectively.
    • Using a wildcard will only accept all tpahere requests, as players can't teleport to multiple places simultaneously.
  • /tpdeny: now allows you to specify a player or * to deny a specific player's or all players' teleport request(s) respectively.

This PR also adds a new setting for the maximum amount of pending TPA requests a user can have at once.

# The maximum amount of simultaneous tpa requests that can be pending for any given user.
# Once at this threshold, any new tpa requests will bump the oldest tpa requests out of queue.
# Defaults to 5.
tpa-max-amount: 5

Closes #3769
Closes #1550

@JRoy JRoy added the type: enhancement Features and feature requests. label Nov 30, 2020
@JRoy JRoy added this to the 2.19.0 milestone Nov 30, 2020
@JRoy JRoy requested a review from mdcfe November 30, 2020 05:10
@JRoy
Copy link
Member Author

JRoy commented Jan 19, 2021

Concerns Addressed

@JRoy JRoy requested a review from mdcfe January 19, 2021 16:19
@mdcfe mdcfe self-assigned this Mar 6, 2021
@JRoy JRoy mentioned this pull request May 19, 2021
mdcfe
mdcfe previously requested changes Aug 29, 2021
Essentials/src/main/resources/messages.properties Outdated Show resolved Hide resolved
@JRoy JRoy requested a review from mdcfe September 8, 2021 21:51
@JRoy JRoy dismissed mdcfe’s stale review September 8, 2021 21:51

:DinkDonk:

@JRoy JRoy requested a review from mdcfe November 20, 2021 22:53
@JRoy JRoy dismissed mdcfe’s stale review November 30, 2021 18:57

nitpicking and bias

@mdcfe mdcfe changed the title Add support for multiple simultaneous TPA requests Add support for multiple queued TPA requests Dec 4, 2021
@mdcfe mdcfe merged commit 7794634 into EssentialsX:2.x Dec 4, 2021
@mdcfe mdcfe deleted the feature/tp-accept-queue branch December 4, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.
Projects
None yet
4 participants