Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to accept multiple simultaneous /tpa requests #3769

Closed
Crumb5 opened this issue Nov 11, 2020 · 1 comment · Fixed by #3801
Closed

Support to accept multiple simultaneous /tpa requests #3769

Crumb5 opened this issue Nov 11, 2020 · 1 comment · Fixed by #3801
Labels
type: enhancement Features and feature requests.
Milestone

Comments

@Crumb5
Copy link

Crumb5 commented Nov 11, 2020

Feature request

Currently the player to player teleport system only holds one pending value for a receiving player even if multiple teleport requests are made.

Feature description:

The system should hold more than one pending teleport.
The/tpaccept <PlayerName> argument should be able to select for valid pending teleport requests from <PlayerName>
Subsequent uses of /tpaccept should iterate through pending teleports until there are no more left.

How the feature is useful:

This prevents confusion to Player A who currently gets no feedback that their teleport request to Player C was overwritten by Player B

@Crumb5 Crumb5 added the type: enhancement Features and feature requests. label Nov 11, 2020
@molor
Copy link

molor commented Nov 11, 2020

+ /tpaccept * to accept all pending requests

@JRoy JRoy added this to the 2.19.0 milestone Nov 15, 2020
@mdcfe mdcfe modified the milestones: 2.19.0, 2.19.1 Aug 19, 2021
mdcfe added a commit that referenced this issue Dec 4, 2021
This PR adds support for players to receive multiple teleport requests, which are queued and can be managed independently of one another.

All commands should retain their current behavior but have some new additions;
* `/tpaccept`: now allows you to specify a player or `*` to accept a specific player's or all players' teleport request(s) respectively.
  - Using a wildcard will only accept all tpahere requests, as players can't teleport to multiple places simultaneously.
* `/tpdeny`: now allows you to specify a player or `*` to deny a specific player's or all players' teleport request(s) respectively.

This PR also adds a new setting for the maximum amount of pending TPA requests a user can have at once.
```yml
# The maximum amount of simultaneous tpa requests that can be pending for any given user.
# Once at this threshold, any new tpa requests will bump the oldest tpa requests out of queue.
# Defaults to 5.
tpa-max-amount: 5
```

Closes #3769
Closes #1550

Co-authored-by: Mariell Hoversholm <proximyst@proximy.st>
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants