Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade node to 16.20.2 #998

Merged
merged 3 commits into from
Nov 11, 2024
Merged

feat: Upgrade node to 16.20.2 #998

merged 3 commits into from
Nov 11, 2024

Conversation

munen
Copy link
Collaborator

@munen munen commented Nov 9, 2024

Works on: #992

Since #993 is proving to be a pretty big PR, I thought I'll try how far we can go without having to 'change all the things'. We can at least go up four major versions.

Node v16.20.2 has been released on 2023-08-08. It's not an LTS release, but it's also not super old. I'd like to see it as a pragmatic interim upgrade. For CircleCI, the latest v16 release is 16.3.1.

I'm not saying we shouldn't do more upgrades. I'm just trying to help out in the original task. My hope is that it'll get easier if we do it step by step.

@schoettl What do you think?


Update some 5h later: This strategy was pretty successful. I think you might like the follow-follow-up PR /~https://github.com/200ok-ch/organice/pulls 🥳

@munen munen requested a review from schoettl November 9, 2024 16:39
Copy link
Collaborator

@schoettl schoettl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good step forward. On my system, yarn install hangs at 0/2132 when starting with clean node environment (node version 20.15.1 though). But that's probably a NixOS problem and shouldn't keep you from merging.

@munen
Copy link
Collaborator Author

munen commented Nov 11, 2024

Let's hope it's a nix, yarn version or node version thing. If it persists, I'm happy to do a pairing session on it.

@munen munen merged commit 4584e60 into master Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants