Feat: Upgrade Create-React-App to 4.0.3 #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use sass only for the landing page. Versions >1.44.0 warn for
an API change. But we only need to require one file. I didn't see
how to use the new API without hitting the warning. We already
just upgraded from node-sass to sass. So we can work with a
slightly older new library, I'd say(;
One of your dependencies, babel-preset-react-app, is importing
the "@babel/plugin-proposal-private-property-in-object" package
without declaring it in its dependencies. This is currently
working because
"@babel/plugin-proposal-private-property-in-object" is already in
your node_modules folder for unrelated reasons, but it may break
at any time.
babel-preset-react-app is part of the create-react-app project,
which is not maintianed anymore. It is thus unlikely that this
bug will ever be fixed. Add
"@babel/plugin-proposal-private-property-in-object" to your
devDependencies to work around this error. This will make this
message go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on: #992
Builds upon #998.