Feat/scrollable modals #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drawers are scrolled differently on mobile and desktop. On the
desktop, the user can see the header of the drawer (for example
the search term) and just scroll the results whereas on mobile
the user can only scroll the whole modal.
munen
force-pushed
the
feat/scrollable-modals
branch
from
c73c2b5 to
0500395
Compare
|
@tarnung Sweet, happy to hear that task lists can be scrolled on Android, again. And, of course, you're right that I've added the comment back and explained the rationale for it a bit more in the commit: 699850b I've also added attribution. Happy to merge, good work as always! 🙏 |
|
Closes #514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#514
overflow: noneis not a thing so I don't do anything instead.I used the bowser function
getPlatformTypeinstead of the custom query to determine whether organice is running in a mobile browser. Before isMobileBrowser alyways was undefined for me, on windows and android.I verified that this returns the right result on windows and android.