Skip to content

Commit

Permalink
doc: UX caviat
Browse files Browse the repository at this point in the history
     Drawers are scrolled differently on mobile and desktop. On the
     desktop, the user can see the header of the drawer (for example
     the search term) and just scroll the results whereas on mobile
     the user can only scroll the whole modal.
  • Loading branch information
munen committed Nov 14, 2020
1 parent 147da63 commit 699850b
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/components/OrgFile/components/AgendaModal/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,11 @@ function AgendaModal(props) {

<div
className="agenda__days-container"
// On mobile devices, the Drawer already handles the touch
// event. Hence, scrolling within the Drawers container does
// not work with the same event. Therefore, we're just opting
// to scroll the whole drawer. That's not the best UX. And a
// better CSS juggler than me is welcome to improve on it.
style={isMobileBrowser ? undefined : { overflow: 'auto' }}
>
{dates.map((date) => (
Expand Down
5 changes: 5 additions & 0 deletions src/components/OrgFile/components/TaskListModal/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ function TaskListModal(props) {

<div
className="task-list__headers-container"
// On mobile devices, the Drawer already handles the touch
// event. Hence, scrolling within the Drawers container does
// not work with the same event. Therefore, we're just opting
// to scroll the whole drawer. That's not the best UX. And a
// better CSS juggler than me is welcome to improve on it.
style={isMobileBrowser ? undefined : { overflow: 'auto' }}
>
<TaskListView
Expand Down

0 comments on commit 699850b

Please sign in to comment.