Improve help menu: compact further, style lines, adapt height #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly amend CHANGELOG to indicate improved height adaptation.
rht
reviewed
Feb 15, 2019
| height=rows//2 | ||
| # +2 to both of the following, due to LineBox | ||
| width=help_view.width+2, | ||
| height=min(3*rows//4, help_view.number_of_actions)+2 |
There was a problem hiding this comment.
No objection. I have no strong position on the exact fraction of the screen. Upon measuring the webapp's ratio more carefully, it's ~70%.
|
@neiljp looks great! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick follow-up to the help menu observation and contribution by @matrixise in #298 and #297.
This PR:
The latter does increase the menu height slightly (it was set to 1/2 in #298), so any feedback through testing would be good.
Tagging @amanagr & @rht who also gave feedback on the PR by @matrixise.