Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact the help view #297

Closed
matrixise opened this issue Feb 12, 2019 · 7 comments
Closed

Compact the help view #297

matrixise opened this issue Feb 12, 2019 · 7 comments

Comments

@matrixise
Copy link
Contributor

matrixise commented Feb 12, 2019

Because the HelpView takes the complete size of my screen (this one is a 25"), I prefer to use a small interface for the shortcuts.

@neiljp
Copy link
Collaborator

neiljp commented Feb 13, 2019

Just to clarify, do you mean a small screen, or rather a certain text resolution?

I have a much smaller (laptop) screen, and with the extra lines currently present I can see all but one of the help lines. However, if the font was larger (and so there were fewer text lines) I could see that being an issue, but then we scroll anyway?

Could you describe the problem a little more?

I do think that removing the lines could be good, as long as we have something similar to address the matching by-eye of the actions to the keys, but I'd appreciate knowing your motivation in this case :)

@matrixise
Copy link
Contributor Author

Hi @neiljp
Here is a screenshot with the help.
zulip-term

@neiljp
Copy link
Collaborator

neiljp commented Feb 15, 2019

@matrixise This is not a match for the current development release - the menu is a lot more compact, at least horizontally. The current help looks more like the screenshots in #265 (merged ~18 days ago).
Note there has also been a change subsequent to that, to make '?' toggle help, rather than require 'esc', which simplifies the menu title.

@neiljp
Copy link
Collaborator

neiljp commented Feb 16, 2019

@matrixise If you're willing to update your development copy, I'd appreciate if you'd consider whether we've reached a suitable level of improvement to close this issue, given the merger of your PR and #301.

@matrixise
Copy link
Contributor Author

@neiljp I will do it asap (maybe tomorrow)

@neiljp
Copy link
Collaborator

neiljp commented Mar 5, 2019

@matrixise Just checking in with you regarding this issue.

@neiljp
Copy link
Collaborator

neiljp commented Jun 21, 2019

@matrixise I'm closing this for now since we've not heard from you and the help menu is dramatically changed.

If you have other suggestions/ideas, please open another issue or discuss on #zulip-terminal on chat.zulip.org.

@neiljp neiljp closed this as completed Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants