This repository has been archived by the owner on Dec 13, 2024. It is now read-only.
Fix failing submission tests for net8.0-xcode15 updates #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests are passing with the exception of the watchOS intents sample. This is because of a mismatch in min os version support due to the recent change of armv7k arch no longer being supported and the defined version in Xamarin.framework.
This makes us actually treat the extension as an extension, and embed it in the app bundle.
We build using a very specific version of .NET + our workloads, so make sure to use the .NET version we want (the current one), instead of an older .NET version.
rolfbjarne
approved these changes
Sep 7, 2023
dalexsoto
approved these changes
Sep 7, 2023
haritha-mohan
added a commit
that referenced
this pull request
Oct 13, 2023
* Fix failing submission tests for net8.0-xcode15 updates (#55) * Fix failing submission tests for net8.0-xcode15 updates All tests are passing with the exception of the watchOS intents sample. This is because of a mismatch in min os version support due to the recent change of armv7k arch no longer being supported and the defined version in Xamarin.framework. --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * Update WatchOSIntents version and arch for Xcode 15 (#56) --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests are passing with the exception of the watchOS intents sample. This is because of a mismatch in min os version support due to the recent change of armv7k arch no longer being supported and the defined version in Xamarin.framework.
Contributes to /~https://github.com/xamarin/maccore/issues/2696
armv7k issue: dotnet/macios#18902
xamarin.framework versions updated: dotnet/macios#18912
Merge after #53 , #54