Skip to content
This repository has been archived by the owner on Dec 13, 2024. It is now read-only.

Merge net8.0-xcode15 into main #57

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Merge net8.0-xcode15 into main #57

merged 3 commits into from
Oct 13, 2023

Conversation

haritha-mohan
Copy link
Contributor

@haritha-mohan haritha-mohan commented Oct 11, 2023

No description provided.

haritha-mohan and others added 3 commits September 7, 2023 10:07
* Fix failing submission tests for net8.0-xcode15 updates

All tests are passing with the exception of the watchOS intents sample.
This is because of a mismatch in min os version support due to the recent
change of armv7k arch no longer being supported and the defined version
in Xamarin.framework.

---------

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
@haritha-mohan haritha-mohan marked this pull request as ready for review October 11, 2023 21:45
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh maybe this is not needed anymore

<EnablePreviewFeatures>True</EnablePreviewFeatures>

@haritha-mohan
Copy link
Contributor Author

haritha-mohan commented Oct 13, 2023

discussed offline with @dalexsoto, but leaving the preview feature prop as is, as this will enable us to run the tests more seamlessly with future version updates. Also based on this design doc we will get the appropriate error if something weird were to happen:

So you'll only be able to use preview features when the TFM and the SDK match. This ensures that users get an error message if, for example, they try to use a preview feature in .NET 6 but they are using the .NET 7 SDK.

@haritha-mohan haritha-mohan merged commit 686ed57 into main Oct 13, 2023
@haritha-mohan haritha-mohan deleted the net8.0-xcode15 branch October 13, 2023 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants