Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ko-KR): update images.mdx #11091

Merged
merged 3 commits into from
Feb 28, 2025
Merged

i18n(ko-KR): update images.mdx #11091

merged 3 commits into from
Feb 28, 2025

Conversation

jsparkdev
Copy link
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Feb 28, 2025
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7cac3d1
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67c1c9c5a457a800085385e8
😎 Deploy Preview https://deploy-preview-11091--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 28, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ko/guides/images.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for these changes!
However, I noticed that the line numbers didn't match, so I quickly checked the rest of the file. It seems that some parts don't match the English version. For example:

  • ko:
    - 인증된 소스에서 가져오는 [구성된 원격 이미지](#원격-이미지-승인)
    `public/` 폴더에 있는 이미지와 프로젝트에 특별히 구성되지 않은 원격 이미지도 이미지 컴포넌트와 함께 사용할 수 있지만 처리되지는 않습니다.
    `<Image />`는 표시된 이미지를 제어하기 위해 로컬 또는 인증된 원격 이미지의 크기, 파일 유형 및 품질을 변환할 수 있습니다. 결과 `<img>` 태그에는 `alt`, `loading``decoding` 속성이 포함되며 CLS (Cumulative Layout Shift)를 방지하기 위해 이미지 크기를 유추합니다.
  • en:
    - [configured remote images](#authorizing-remote-images) from authorized sources
    `<Image />` can transform a local or authorized remote image's dimensions, file type, and quality for control over your displayed image. The resulting `<img>` tag includes `alt`, `loading`, and `decoding` attributes and infers image dimensions to avoid Cumulative Layout Shift (CLS).
    (the public/ line does not exist here)

So I'll let you merge if you want to check the rest of the file in another PR.

@jsparkdev
Copy link
Member Author

@ArmandPhilippot

Thanks for the nice catch!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit 90f0edc into withastro:main Feb 28, 2025
10 checks passed
@jsparkdev jsparkdev deleted the images branch February 28, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants