-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass-import: update to 3.3. #40801
pass-import: update to 3.3. #40801
Conversation
srcpkgs/pass-import/template
Outdated
hostmakedepends="python3-setuptools python3-pypandoc python3-requests python3-yaml | ||
python3-zxcvbn" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch distfiles
to PYPI_SITE
https://pypi.org/project/pass-import/#files, pypandoc
is not very welcome in hostmakedepends
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes will do this evening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to PYPI_SITE and removed the makedoc from setup.py. There are no tests in these sources, so do I drop the checkdepends altogether?
10940a1
to
d52dbd8
Compare
srcpkgs/pass-import/template
Outdated
distfiles="${PYPI_SITE}/p/pass-import/pass-import-${version}.tar.gz" | ||
# distfiles="https://files.pythonhosted.org/packages/source/p/pass-import/pass-import-3.3.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this comment here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it was a mistake. Still looking at the ./xbps-src check
d52dbd8
to
8711b93
Compare
depends="pass python3-defusedxml python3-magic python3-cryptography | ||
python3-SecretStorage python3-pykeepass python3-yaml" | ||
checkdepends="python3-pytest $depends" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't remove pytest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, the pypi tarball doesn't have tests, in that case, could you just add
# pypi tarball doesn't contain tests and the github release doesn't contain pre-built manpages (is this true?)
# <link to sgn's issue>
make_check=no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the first iteration did build from github and it requires pandoc to build markdown man files
ls -l share/man/man1/
-rw-r--r-- 1 alan alan 20046 Sep 10 23:19 pass-import.md
-rw-r--r-- 1 alan alan 8795 Sep 10 23:19 pimport.md
c5d80f4
to
4c2f254
Compare
4c2f254
to
c8fc988
Compare
Testing the changes