Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass-import: update to 3.3. #40801

Merged
merged 1 commit into from
Dec 3, 2022
Merged

pass-import: update to 3.3. #40801

merged 1 commit into from
Dec 3, 2022

Conversation

adbrown101
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@adbrown101 adbrown101 mentioned this pull request Nov 27, 2022
Comment on lines 8 to 9
hostmakedepends="python3-setuptools python3-pypandoc python3-requests python3-yaml
python3-zxcvbn"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch distfiles to PYPI_SITE https://pypi.org/project/pass-import/#files, pypandoc is not very welcome in hostmakedepends

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will do this evening

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to PYPI_SITE and removed the makedoc from setup.py. There are no tests in these sources, so do I drop the checkdepends altogether?

Comment on lines 16 to 17
distfiles="${PYPI_SITE}/p/pass-import/pass-import-${version}.tar.gz"
# distfiles="https://files.pythonhosted.org/packages/source/p/pass-import/pass-import-3.3.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this comment here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it was a mistake. Still looking at the ./xbps-src check

depends="pass python3-defusedxml python3-magic python3-cryptography
python3-SecretStorage python3-pykeepass python3-yaml"
checkdepends="python3-pytest $depends"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't remove pytest

Copy link
Member

@paper42 paper42 Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, the pypi tarball doesn't have tests, in that case, could you just add

# pypi tarball doesn't contain tests and the github release doesn't contain pre-built manpages (is this true?)
# <link to sgn's issue>
make_check=no

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the first iteration did build from github and it requires pandoc to build markdown man files

ls -l share/man/man1/
-rw-r--r-- 1 alan alan 20046 Sep 10 23:19 pass-import.md
-rw-r--r-- 1 alan alan  8795 Sep 10 23:19 pimport.md

@adbrown101 adbrown101 force-pushed the pass-import branch 2 times, most recently from c5d80f4 to 4c2f254 Compare December 3, 2022 15:56
@sgn sgn merged commit 2b44e7a into void-linux:master Dec 3, 2022
@adbrown101 adbrown101 deleted the pass-import branch December 4, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants