Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship manpage with GitHub tarball? (match with PyPI) #192

Closed
sgn opened this issue Nov 27, 2022 · 5 comments
Closed

Ship manpage with GitHub tarball? (match with PyPI) #192

sgn opened this issue Nov 27, 2022 · 5 comments

Comments

@sgn
Copy link
Contributor

sgn commented Nov 27, 2022

Hi, since you will upload tarball into PyPI anyway,
Could you please also upload it into GitHub, or at least include man-pages in generated tarball?

That would save the trouble: time to build documentation, haskell is hard to be built on some platform.

@roddhjav
Copy link
Owner

roddhjav commented Dec 4, 2022

Hi, I do agree, the new build deps add some issue. I will build the doc during the release process and remove this deps. This will go into the next release (hopefully soon).

@roddhjav
Copy link
Owner

Should be fixed with pass-import 3.4

@mcepl
Copy link

mcepl commented Jan 9, 2024

I don’t think this has been fixed (the tarball from GitHub):

 $ tar tvf pass-import-3.4.tar.gz |grep -w man
drwxrwxr-x root/root         0 2022-12-10 16:01 pass-import-3.4/share/man/
drwxrwxr-x root/root         0 2022-12-10 16:01 pass-import-3.4/share/man/man1/
-rw-rw-r-- root/root     19352 2022-12-10 16:01 pass-import-3.4/share/man/man1/pass-import.md
-rw-rw-r-- root/root     20586 2022-12-10 16:01 pass-import-3.4/share/man/man1/pimport.md
 $ 

@roddhjav
Copy link
Owner

roddhjav commented Jan 9, 2024

You need to take the signed asset, not the default github talbar.

@mcepl
Copy link

mcepl commented Jan 9, 2024

Right, that’s a PEBKAC. Sorry for bothering you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants