Implementation -- Bugfixes #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonowak
reviewed
May 3, 2023
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
tonowak
reviewed
May 3, 2023
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
tonowak
approved these changes
May 5, 2023
obi1kenobi
reviewed
May 5, 2023
|
|
||
| Another important part of our work was diagnosing the issues present in the tool. | ||
| Throughout our contributions to the project, we managed to fix the following bugs: | ||
| \begin{itemize} |
There was a problem hiding this comment.
Consider sorting these in order of "how interesting they are" to the reader.
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
|
@tonowak so the last thing left to resolve - the order of the items. Their relevance might be hard to compare and I think it's not worth spending a lot of time on, but I moved some that looked less severe down the lists. |
tonowak
approved these changes
May 8, 2023
SmolSir
added a commit
that referenced
this pull request
May 21, 2023
* Implementation -- Brand new GitHub Action (#37) * Describe action implementation * Fix section link * Mention cache-related inputs * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Implementation -- Bugfixes (#40) * List buggggs * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Reorder the bugs --------- Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Implementation: CLI improvements (#39) * Describe feature configuration * Change font on a feature name * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Review adjustments * Minor adjustments * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Implementation -- Healthier codebase (#36) * done I guess? * remove a comment * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Comment out the binaries paragraph * add ref * remove the yanked part (not really codebase-related) * rearrange awareness * test suite * smaller changes mentioned --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Implementation: new lints (#35) * List new lints * More info on the adapter * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Add more info on solution used * Add semver break reasons * Update thesis-en.tex * Update thesis-en.tex * Review adjustments * asdasd * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Implementation -- test suite (#30) * Implementation -- test suite * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * CI tests reasons * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Implementation -- Brand new GitHub action (#44) * Describe action implementation * Fix section link * Mention cache-related inputs * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> Co-authored-by: Michał Staniewski <m.staniewzki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.