Implementation -- Brand new GitHub Action #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmolSir
reviewed
May 2, 2023
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com>
Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com>
Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com>
|
Wow, this seems like everything resolved? Thank you for the effort you put in reviewing this PR @SmolSir! |
Reviews are a lot of fun after all, even if they take some time! |
tonowak
reviewed
May 3, 2023
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com>
Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com>
tonowak
reviewed
May 3, 2023
tonowak
reviewed
May 3, 2023
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com>
tonowak
reviewed
May 3, 2023
tonowak
approved these changes
May 3, 2023
| <Here write a list about the V2 of the continuous integration> | ||
| The V1 version of cargo-semver-checks-action was created when | ||
| cargo-semver-checks lacked a built-in logic of choosing the correct baseline version and was not | ||
| generating the rustdoc output automatically. Both of these tasks where therefore handled by the action. |
There was a problem hiding this comment.
Suggested change
| generating the rustdoc output automatically. Both of these tasks where therefore handled by the action. | |
| generating the rustdoc output automatically. Both of these tasks were therefore handled by the action. |
| of creating complex actions, as it has multiple advantages: | ||
| \begin{itemize} | ||
| \item TypeScript action is platform-independent and can be run on all runners supported by GitHub Actions. | ||
| \item Using Node.js makes it possible to depend on variety of \texttt{npm} packages, in particular the GitHub Actions |
There was a problem hiding this comment.
Suggested change
| \item Using Node.js makes it possible to depend on variety of \texttt{npm} packages, in particular the GitHub Actions | |
| \item Using Node.js makes it possible to depend on a variety of \texttt{npm} packages, in particular the GitHub Actions |
Comment on lines
+755
to
+765
| \item input \texttt{rust-toolchain}, which allows the user to specify the Rust toolchain to use instead | ||
| of the default \texttt{stable}, | ||
| \item inputs \texttt{package} and \texttt{exclude}, both accepting lists of package names, | ||
| allowing to define the exact set of packages to be checked, | ||
| \item input \texttt{manifest-path}, which allows to specify the path to the \texttt{Cargo.toml} file | ||
| of the crate or workspaces to be processed if it is not located in the directory where | ||
| the action is run, | ||
| \item input \texttt{verbose}, which might be used to enable extended output of the tool, | ||
| providing details about every executed lint, | ||
| \item input \texttt{release-type}, with possible values \texttt{major}, \texttt{minor} and \texttt{patch}, | ||
| allowing to specify the type of the release instead of deducing it from the crate's version change. |
There was a problem hiding this comment.
Shouldn't it be an input (besides inputs)?
|
Oh come on |
|
when did I give an approve, huh? |
SmolSir
added a commit
that referenced
this pull request
May 8, 2023
* Implementation -- Brand new GitHub Action (#37) * Describe action implementation * Fix section link * Mention cache-related inputs * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * supervisor-5.1 -> supervisor-ch-5 (#58) * List new lints * More info on the adapter * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Add more info on solution used * Add semver break reasons * Update thesis-en.tex * Update thesis-en.tex * Review adjustments * asdasd * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> --------- Co-authored-by: Michał Staniewski <m.staniewzki@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * supervisor-5.2 -> supervisor-ch-5 (#57) * Describe feature configuration * Change font on a feature name * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Review adjustments * Minor adjustments * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex --------- Co-authored-by: Michał Staniewski <m.staniewzki@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * supervisor-5.3 -> supervisor-ch-5 (#56) * Describe action implementation * Fix section link * Mention cache-related inputs * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * supervisor-5.4 -> supervisor-ch-5 (#54) * Implementation -- test suite * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * CI tests reasons * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex --------- Co-authored-by: Tomasz Nowak <tomek.nowak.gm.16@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * supervisor-5.5 -> supervisor-ch-5 (#55) * done I guess? * remove a comment * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Comment out the binaries paragraph * add ref * remove the yanked part (not really codebase-related) * rearrange awareness * test suite * smaller changes mentioned --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * supervisor-5.6 -> supervisor-ch-5 (#53) * List buggggs * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Michał Staniewski <m.staniewzki@gmail.com> Co-authored-by: Tomasz Nowak <tomek.nowak.gm.16@gmail.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
SmolSir
added a commit
that referenced
this pull request
May 21, 2023
* Implementation -- Brand new GitHub Action (#37) * Describe action implementation * Fix section link * Mention cache-related inputs * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Implementation -- Bugfixes (#40) * List buggggs * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Reorder the bugs --------- Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Implementation: CLI improvements (#39) * Describe feature configuration * Change font on a feature name * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Review adjustments * Minor adjustments * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Implementation -- Healthier codebase (#36) * done I guess? * remove a comment * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Comment out the binaries paragraph * add ref * remove the yanked part (not really codebase-related) * rearrange awareness * test suite * smaller changes mentioned --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Implementation: new lints (#35) * List new lints * More info on the adapter * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Add more info on solution used * Add semver break reasons * Update thesis-en.tex * Update thesis-en.tex * Review adjustments * asdasd * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Implementation -- test suite (#30) * Implementation -- test suite * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * CI tests reasons * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex * Update thesis-en.tex --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> * Implementation -- Brand new GitHub action (#44) * Describe action implementation * Fix section link * Mention cache-related inputs * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> * Update thesis-en.tex * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> * Update thesis-en.tex * Apply suggestions from code review Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> --------- Co-authored-by: Bartosz Smolarczyk <92160712+SmolSir@users.noreply.github.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> --------- Co-authored-by: Mieszko Grodzicki <mieszko.grodzicki@gmail.com> Co-authored-by: Tomasz Nowak <36604952+tonowak@users.noreply.github.com> Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> Co-authored-by: Michał Staniewski <m.staniewzki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.