Release 8.0.0 #662

max-rocket-internet · 2020-01-06T16:28:34Z

Waiting on these 2 PRs to be merged:

Resolves #635
Resolves #628

max-rocket-internet · 2020-01-09T12:21:27Z

Some ugly output from #639

module.eks.aws_eks_cluster.this[0]: Still creating... [10m1s elapsed]
module.eks.aws_eks_cluster.this[0]: Still creating... [10m11s elapsed]
module.eks.aws_eks_cluster.this[0]: Provisioning with 'local-exec'...
module.eks.aws_eks_cluster.this[0] (local-exec): Executing: ["/bin/sh" "-c" "    until curl -k https://106D3ABA497FF44D1B14389CAF75A3B4.yl4.us-west-2.eks.amazonaws.com/healthz >/dev/null; do sleep 4; done\n"]
module.eks.aws_eks_cluster.this[0] (local-exec):   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
module.eks.aws_eks_cluster.this[0] (local-exec):                                  Dload  Upload   Total   Spent    Left  Speed
module.eks.aws_eks_cluster.this[0] (local-exec):   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
module.eks.aws_eks_cluster.this[0] (local-exec):   0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
module.eks.aws_eks_cluster.this[0] (local-exec):   0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
module.eks.aws_eks_cluster.this[0] (local-exec):   0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0

I think we can fix this by adding -s to the curl command.

max-rocket-internet · 2020-01-09T12:36:35Z

examples/managed_node_groups/main.tf

@@ -113,7 +113,6 @@ module "eks" {
        ExtraTag = "example"
      }
    }
-    defaults = {}


@dpiddockcmp is it OK remove this? Without removing this, the example creates 2 node groups where I think it should be a single?

Should be fine. It was for testing some of the for_each and ternary logic. Terraform gets more unpredictable with multiple items. Used to confirm the fix in #633

max-rocket-internet · 2020-01-09T13:01:39Z

OK apart from the 2 node group creation and the ugly output from curl, all 4 examples init, plan, apply, all nodes Ready and then destroy without any errors at all 🎉

barryib

LGTM.

max-rocket-internet · 2020-01-09T13:10:38Z

I'm gonna ignore the Lint error for now, I think there's a fix in another PR.

* Don't fail on destroy, when provider resource was removed * Update Changelog * Node groups submodule (#650) * WIP Move node_groups to a submodule * Split the old node_groups file up * Start moving locals * Simplify IAM creation logic * depends_on from the TF docs * Wire in the variables * Call module from parent * Allow to customize the role name. As per workers * aws_auth ConfigMap for node_groups * Get the managed_node_groups example to plan * Get the basic example to plan too * create_eks = false works "The true and false result expressions must have consistent types. The given expressions are object and object, respectively." Well, that's useful. But apparently set(string) and set() are ok. So everything else is more complicated. Thanks. * Update Changelog * Update README * Wire in node_groups_defaults * Remove node_groups from workers_defaults_defaults * Synchronize random and node_group defaults * Error: "name_prefix" cannot be longer than 32 * Update READMEs again * Fix double destroy Was producing index errors when running destroy on an empty state. * Remove duplicate iam_role in node_group I think this logic works. Needs some testing with an externally created role. * Fix index fail if node group manually deleted * Keep aws_auth template in top module Downside: count causes issues as usual: can't use distinct() in the child module so there's a template render for every node_group even if only one role is really in use. Hopefully just output noise instead of technical issue * Hack to have node_groups depend on aws_auth etc The AWS Node Groups create or edit the aws-auth ConfigMap so that nodes can join the cluster. This breaks the kubernetes resource which cannot do a force create. Remove the race condition with explicit depend. Can't pull the IAM role out of the node_group any more. * Pull variables via the random_pet to cut logic No point having the same logic in two different places * Pass all ForceNew variables through the pet * Do a deep merge of NG labels and tags * Update README.. again * Additional managed node outputs #644 Add change from @TBeijin from PR #644 * Remove unused local * Use more for_each * Remove the change when create_eks = false * Make documentation less confusing * node_group version user configurable * Pass through raw output from aws_eks_node_groups * Merge workers defaults in the locals This simplifies the random_pet and aws_eks_node_group logic. Which was causing much consernation on the PR. * Fix typo Co-authored-by: Max Williams <max.williams@deliveryhero.com> * Update Changelog * Add public access endpoint CIDRs option (terraform-aws-eks#647) (#673) * Add public access endpoint CIDRs option (terraform-aws-eks#647) * Update required provider version to 2.44.0 * Fix formatting in docs * Re-generate docs with terraform-docs 0.7.0 and bump pre-commit-terraform version (#668) * re-generate docs with terraform-docs 0.7.0 * bump pre-commit-terraform version * Release 8.0.0 (#662) * Release 8.0.0 * Update changelog * remove 'defauls' node group * Make curl silent * Update Changelog Co-authored-by: Daniel Piddock <33028589+dpiddockcmp@users.noreply.github.com> Co-authored-by: Max Williams <max.williams@deliveryhero.com> Co-authored-by: Siddarth Prakash <1428486+sidprak@users.noreply.github.com> Co-authored-by: Thierno IB. BARRY <ibrahima.br@gmail.com>

github-actions · 2022-11-20T02:31:48Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

max-rocket-internet added the on hold label Jan 6, 2020

This was referenced Jan 8, 2020

Add destroy time flag #580

Merged

Add IRSA support #632

Merged

max-rocket-internet added 2 commits January 9, 2020 13:01

Release 8.0.0

68c2dc8

Update changelog

3d5092d

max-rocket-internet removed the on hold label Jan 9, 2020

max-rocket-internet requested a review from barryib January 9, 2020 12:07

remove 'defauls' node group

2e127d0

max-rocket-internet commented Jan 9, 2020

View reviewed changes

Make curl silent

b878749

max-rocket-internet mentioned this pull request Jan 9, 2020

Not able to attach security group in Managed node group #665

Closed

barryib approved these changes Jan 9, 2020

View reviewed changes

max-rocket-internet merged commit a9db852 into terraform-aws-modules:master Jan 9, 2020

max-rocket-internet deleted the release_8.0.0 branch January 9, 2020 13:10

exequielrafaela mentioned this pull request Jan 14, 2020

Sync w/ v8.0.0 -> Node groups, IRSA, k8s provider, wow🔥 binbashar/terraform-aws-eks#6

Merged

github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 8.0.0 #662

Release 8.0.0 #662

max-rocket-internet commented Jan 6, 2020

max-rocket-internet commented Jan 9, 2020 •

edited

Loading

max-rocket-internet Jan 9, 2020 •

edited

Loading

dpiddockcmp Jan 9, 2020

max-rocket-internet commented Jan 9, 2020

barryib left a comment

max-rocket-internet commented Jan 9, 2020

github-actions bot commented Nov 20, 2022

Release 8.0.0 #662

Release 8.0.0 #662

Conversation

max-rocket-internet commented Jan 6, 2020

max-rocket-internet commented Jan 9, 2020 • edited Loading

max-rocket-internet Jan 9, 2020 • edited Loading

Choose a reason for hiding this comment

dpiddockcmp Jan 9, 2020

Choose a reason for hiding this comment

max-rocket-internet commented Jan 9, 2020

barryib left a comment

Choose a reason for hiding this comment

max-rocket-internet commented Jan 9, 2020

github-actions bot commented Nov 20, 2022

max-rocket-internet commented Jan 9, 2020 •

edited

Loading

max-rocket-internet Jan 9, 2020 •

edited

Loading