Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you do a new release with node groups? #628

Closed
davisford opened this issue Dec 11, 2019 · 7 comments · Fixed by #662
Closed

Can you do a new release with node groups? #628

davisford opened this issue Dec 11, 2019 · 7 comments · Fixed by #662

Comments

@davisford
Copy link

I have issues

We are trying to use the cluster auto-scaler with EKS. EKS requires node groups to work properly with auto scaler. I see you've added support for node groups on Dec. 4. Is it possible to create a new release? We are having trouble trying to pull the module down by git hash, but perhaps I am missing something.

@max-rocket-internet
Copy link
Contributor

EKS requires node groups to work properly with auto scaler

No it doesn't. Or you mean a different autoscaler? Like not the cluster-autoscaler?

Is it possible to create a new release?

I'm keen to do this but there's a few issues that I think we should resolve first:

#623
#627

@davisford perhaps you could test that PR?

@davisford
Copy link
Author

davisford commented Dec 11, 2019

Yes, I mean the cluster auto-scaler

What I meant is:

If you are running a stateful application across multiple Availability Zones that is backed by Amazon EBS volumes and using the Kubernetes Cluster Autoscaler, you should configure multiple node groups, each scoped to a single Availability Zone. In addition, you should enable the --balance-similar-node-groups feature. Otherwise, you can create a single node group that spans multiple Availability Zones.

Will see if I can test out the PRs -- I assume you mean by actually deploying. I can run TF plan and check the output, but I'm assuming your tests catch that stuff.

@max-rocket-internet
Copy link
Contributor

backed by Amazon EBS volumes and using the Kubernetes Cluster Autoscaler

In this case you create an ASG per AZ. But if you are not using EBS volumes then it doesn't matter.

Will see if I can test out the PRs -- I assume you mean by actually deploying. I can run TF plan and check the output

Great! I am not using managed node groups so can't really test properly.

@davisford
Copy link
Author

Yes, I am using EBS volumes heavily so node groups are important for us.

@iterion
Copy link

iterion commented Jan 6, 2020

It doesn't seem like there is anything to be done for #623 - if there is I'm happy to try to tackle it to unblock a release.

@max-rocket-internet
Copy link
Contributor

@iterion sure but base it off this PR that will be merged very soon: #650

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants