Skip to content

Gendarme.Rules.BadPractice.UseFileOpenOnlyWithFileAccessRule(git)

Sebastien Pouliot edited this page Mar 2, 2011 · 1 revision

UseFileOpenOnlyWithFileAccessRule

Assembly: Gendarme.Rules.BadPractice
Version: git

Description

This rule checks that when file open method is called with FileMode parameter it is also called with FileAccess (or FileSystemRights) parameter. It is needed because default behaviour of file open methods when they are called only with FileMode is to require read-write access while it is commonly expected that they will require only read access.

Examples

Bad example:

public void OpenFile ()
{
    FileStream f = File.Open ("Filename.ext", FileMode.Open);
}

Good example:

public void OpenFile ()
{
    FileStream f = File.Open ("Filename.ext", FileMode.Open, FileAccess.Read);
}

Source code

You can browse the latest source code of this rule on github.com

Clone this wiki locally