-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop
into main
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll push to docker hub
removed wcstools installation from dresscode docker image created wcstools and caldb docker file and image
switch to markdown for readme update copyright to AURA add code of conduct add codeowners (automatic reviewers) add link back to original in readme #23
conform to space telescope style guide
Docker GitHub action
* init docs * add remaining pieces of user manual * remove PDF and ref. to PDF in readme switch to running docs only when push to main branch or develop branch * switch to only deploy on main/develop * add logo to main readme file condense Readme (now that we have info easily accessible in docs) * fix public links to docker hub fix spelling * make all external links open in new tab * remove item to delete download script * updated refs to heasoft 6.25 -> 6.28 * wcstools 3.9.5 -> 3.9.6 * add favicon and "logo" update large-logo w/ color that works in dark/light modes * add help section minor fixes for docs steps
* add bash script to download test data and run pipeline * remove interactive term option * correct handling of Raw_images and working_dir paths add step to uncompress images * remove reassignment to itself * option to specify a data volume dir in the test script add docker readme * try the -t option * try to artifact the final images specify path for data into docker container create data dir move data path absolute path try home dir try with workspace variable create galexy dir move pip install into dependency dockerfile switch github action for testing to run inside container build and push dependency docker image on merge to main test main docker push action try volume mounting w/ rw option github location try passing user root into container remove cd command specify location for checked out code specify loc for test & run pipeline command try setting shell try user root with built docker container mount volume for data add python packages to path allow current user to map to container user pass user into docker run command? remove the UID build args add venv remove build-arg apt install venv need root user use bash for source venv add wheel to venv add numpy first in install order try root user again remove dependencies that are now in other dockerfile add source venv to bashrc remove source call source the activate script at top of script grab all the test data see output from pipeline run test pull ubuntu image first debug debug 2 debug set output path on home dir match output fname update docker readme attempt to cache the raw images closes #26 create separate download script for test data test cacheing this download data specify correct bash script name re-enable pipeline in github action only test the pipeline end to end on pull requests and pushes to main/develop branches * remove cache option in pipeline for now, since it only works when the pipeline isn't running * colors for docs that show up better in dark mode * reduce test data set * adds the cache step back using a diff. directory * combine our workflows into one, with conditional on main branch for docker push
mdecleir
reviewed
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Here are some comments/questions:
fix links for docker hub
…sing duplicate runs)
mdecleir
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combination of 3 features