Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SECRETS_PINENTRY env var and docs #490

Merged
merged 13 commits into from
Aug 16, 2019
Merged

Add SECRETS_PINENTRY env var and docs #490

merged 13 commits into from
Aug 16, 2019

Conversation

joshrabinowitz
Copy link
Collaborator

For #221

@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Jun 13, 2019 •
edited
Loading

This can't work with a path to an exe because --pinentry-mode doesn't accept a program argument. See man gpg on gpg after 2.1 Edit: worked around

@joshrabinowitz
Copy link
Collaborator Author

retooling to see if we can use SECRETS_PINENTRY to specify 'default', 'ask', 'cancel', 'error' or 'loopback'.

@joshrabinowitz joshrabinowitz mentioned this pull request Jun 13, 2019
Closed
@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Jun 13, 2019 •
edited
Loading

This is blocked from merging by #487, but when that issue is resolved and the fix merged, I think this PR is ready for merge too.

@joshrabinowitz joshrabinowitz mentioned this pull request Jun 13, 2019
Open
simbo1905
simbo1905 approved these changes Jun 15, 2019
View reviewed changes
Copy link
Collaborator

@simbo1905 simbo1905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshrabinowitz joshrabinowitz mentioned this pull request Aug 16, 2019
Closed
@joshrabinowitz joshrabinowitz merged commit baf6c41 into sobolevn:master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simbo1905 simbo1905 simbo1905 approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshrabinowitz @simbo1905