Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for GPG pinentry issue with git gui #223

Closed
wants to merge 1 commit into from
Closed

Fixes for GPG pinentry issue with git gui #223

wants to merge 1 commit into from

Conversation

ieugen
Copy link

@ieugen ieugen commented Jun 28, 2018

Closes #221

@joshrabinowitz
Copy link
Collaborator

joshrabinowitz commented Jun 29, 2018

Thanks for the patch, @ieugen ! Does this fix your --pinentry issue?

Unfortunately it breaks the git-secret self-tests.
If this does fix your pinentry issue, we need to find the right condition under which to avoid the --pinentry-mode loopback option

@joshrabinowitz
Copy link
Collaborator

Hey @ieugen, ok with you if I close this PR? Issue #221 still tracks the problem.

@ieugen ieugen deleted the patch-1 branch July 15, 2018 11:27
@joshrabinowitz
Copy link
Collaborator

joshrabinowitz commented Jun 13, 2019

Hello @ieugen , I think I've worked up a solution for this issue.

Could you possibly test issue #221 along with the code from PR #490
with the env var SECRETS_PINENTRY set to default and then ask?
I think one or both will allow gpg-agent to use its normal pinentry method.

Please let us know if it works or not, if you get a chance to test it! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git secret + commit hook fails with git gui. Overrides pinentry
2 participants