Move compile-fail tests that are rejected by the parser to parse-fail #22011
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
fhahn
force-pushed
the
separate-parse-fail-tests
branch
2 times, most recently
from
1433256 to
4e544ca
Compare
|
You can also move here these two tests: |
|
@bors r+ 4e544ca nice |
|
very excited to see this infrastructure coming together |
|
Nice. |
|
@Potpourri done. But there are some more files that fail during the parse stage. I'll try to fix the bug mentioned in the description as soon as possible. |
fhahn
force-pushed
the
separate-parse-fail-tests
branch
from
4e544ca to
01db9a4
Compare
bors
added a commit
that referenced
this pull request
Feb 8, 2015
This PR moves all `compile-fail` tests that fail at the parsing stage to a `parse-fail` directory, in order to use the tests in the `parse-fail` directory to test if the new LALR parser rejects the same files as the Rust parser. I also adjusted the `testparser.py` script to handle the tests in `parse-fail` differently. However during working on this, I discovered, that Rust's parser sometimes fails during parsing, but does not return a nonzero return code, e.g. compiling `/test/compile-fail/doc-before-semi.rs` with `-Z parse-only` prints an error message, but returns status code 0. Compiling the same file without `-Z parse-only`, the same error message is displayed, but error code 101 returned. I'll look into that over the next week.
This was referenced Feb 8, 2015
|
Unfortunately I think that this actually stopped running all these tests: #22118 (comment). Don't sweat it too much, but I recommend doing extra tests on Makefile-based changes in the future, we unfortunately don't have automation in place to make sure tests are run! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all
compile-failtests that fail at the parsing stage to aparse-faildirectory, in order to use the tests in theparse-faildirectory to test if the new LALR parser rejects the same files as the Rust parser (as suggested by @brson in #21452). I also adjusted thetestparser.pyscript to handle the tests inparse-faildifferently.However during working on this, I discovered, that Rust's parser sometimes fails during parsing, but does not return a nonzero return code, e.g. compiling
/test/compile-fail/doc-before-semi.rswith-Z parse-onlyprints an error message, but returns status code 0. Compiling the same file without-Z parse-only, the same error message is displayed, but error code 101 returned. I'll look into that over the next week.